Remove methods associated with the builder pattern from TaskTraits.

Remove methods associated with the builder pattern from TaskTraits.

BUG=713683
Review-Url: https://codereview.chromium.org/2871973003
Cr-Commit-Position: refs/heads/master@{#470553}
Committed: https://chromium.googlesource.com/chromium/src/+/b7599ca4415f3dd4325fa31cb4c37704d68e3cca

[fdoray, 2017-05-09 15:35:43]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 15:36:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-09 15:37:18]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-05-09 15:37:19]

PTAL

[commit-bot: I haz the power, 2017-05-09 15:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 15:46:32]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[robliao, 2017-05-09 16:52:22]

lgtm % build issues and comment

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_traits.h:114: // Describes metadata for a single task
or a group of tasks. Immutable.
Immutable is not strictly true since we support assignment. This addition can be
omitted.

[fdoray, 2017-05-09 17:28:51]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 17:29:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-09 17:30:05]

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_traits.h:114: // Describes metadata for a single task
or a group of tasks. Immutable.
On 2017/05/09 16:52:22, robliao wrote:
> Immutable is not strictly true since we support assignment. This addition can
be
> omitted.

Done.

[commit-bot: I haz the power, 2017-05-09 17:41:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 17:41:16]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2017-05-09 18:17:17]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 18:18:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-09 18:41:35]

lgtm % immutable discussion

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_traits.h:114: // Describes metadata for a single task
or a group of tasks. Immutable.
On 2017/05/09 16:52:22, robliao wrote:
> Immutable is not strictly true since we support assignment. This addition can
be
> omitted.

Well, it's immutable in the sense of it can only be mutated by being
re-assigned, just like an int is immutable. The variable's instance must be
"replaced" by another (even though the compiler will replace this instance's
members rather than replace the instance per se, that doesn't matter it's
effectively replaced, it can't be partially tweaked).

https://codereview.chromium.org/2871973003/diff/60001/base/task_scheduler/tas...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2871973003/diff/60001/base/task_scheduler/tas...
base/task_scheduler/task_traits.h:114: // Describes metadata for a single task
or a group of tasks.
Replace with:

// Immutable metadata for a single task or a group of tasks.

[robliao, 2017-05-09 18:47:33]

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_traits.h:114: // Describes metadata for a single task
or a group of tasks. Immutable.
On 2017/05/09 18:41:34, gab wrote:
> On 2017/05/09 16:52:22, robliao wrote:
> > Immutable is not strictly true since we support assignment. This addition
can
> be
> > omitted.
> 
> Well, it's immutable in the sense of it can only be mutated by being
> re-assigned, just like an int is immutable. The variable's instance must be
> "replaced" by another (even though the compiler will replace this instance's
> members rather than replace the instance per se, that doesn't matter it's
> effectively replaced, it can't be partially tweaked).

Discussed offline and the consensus is to add immutable back in.

This should be worded as "Describes immutable metadata for a single task or a
group of tasks."

[fdoray, 2017-05-09 19:22:52]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 19:23:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-09 19:25:52]

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2871973003/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_traits.h:114: // Describes metadata for a single task
or a group of tasks. Immutable.
On 2017/05/09 18:47:33, robliao wrote:
> On 2017/05/09 18:41:34, gab wrote:
> > On 2017/05/09 16:52:22, robliao wrote:
> > > Immutable is not strictly true since we support assignment. This addition
> can
> > be
> > > omitted.
> > 
> > Well, it's immutable in the sense of it can only be mutated by being
> > re-assigned, just like an int is immutable. The variable's instance must be
> > "replaced" by another (even though the compiler will replace this instance's
> > members rather than replace the instance per se, that doesn't matter it's
> > effectively replaced, it can't be partially tweaked).
> 
> Discussed offline and the consensus is to add immutable back in.
> 
> This should be worded as "Describes immutable metadata for a single task or a
> group of tasks."

Done.

[commit-bot: I haz the power, 2017-05-09 20:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 20:15:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2017-05-10 10:16:19]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-05-10 10:16:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2871973003/#ps80001
(title: "immutable")

[commit-bot: I haz the power, 2017-05-10 10:16:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:52:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-05-10 12:53:59]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:54:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 13:41:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494420839759100,
"parent_rev": "53f2bbb667f8807541a82e65688c4e7612ab6c59", "commit_rev":
"b7599ca4415f3dd4325fa31cb4c37704d68e3cca"}

[commit-bot: I haz the power, 2017-05-10 13:42:01]

Description was changed from

==========
Remove methods associated with the builder pattern from TaskTraits.

BUG=713683
==========

to

==========
Remove methods associated with the builder pattern from TaskTraits.

BUG=713683

Review-Url: https://codereview.chromium.org/2871973003
Cr-Commit-Position: refs/heads/master@{#470553}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7599ca4415f3dd4325fa31cb4c3...
==========

[commit-bot: I haz the power, 2017-05-10 13:42:02]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b7599ca4415f3dd4325fa31cb4c3...