Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2872933002: Use constexpr TaskTraits constructor everywhere. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor everywhere. This CL replaces remaining remaining uses of the builder pattern to construct TaskTraits with calls to the constexpr TaskTraits constructor. BUG=713683 TBR=thestig@chromium.org,bauerb@chromium.org,skym@chromium.org Review-Url: https://codereview.chromium.org/2872933002 Cr-Commit-Position: refs/heads/master@{#470487} Committed: https://chromium.googlesource.com/chromium/src/+/224f8c294d66cdb6af36a93ec677859c50dd46e2

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : fix-build-error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M chrome/browser/printing/print_job.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M components/sync/model_impl/model_type_store_impl.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (16 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-09 15:14:18 UTC) #2
Bernhard Bauer
RSLGTM
3 years, 7 months ago (2017-05-09 15:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872933002/40001
3 years, 7 months ago (2017-05-09 18:15:40 UTC) #13
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-09 18:47:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/264064)
3 years, 7 months ago (2017-05-09 19:25:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872933002/40001
3 years, 7 months ago (2017-05-09 21:31:26 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/335547)
3 years, 7 months ago (2017-05-10 01:09:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872933002/40001
3 years, 7 months ago (2017-05-10 04:53:35 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 05:41:40 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/224f8c294d66cdb6af36a93ec677...

Powered by Google App Engine
This is Rietveld 408576698