net: add IsMethodIdempotent() to HttpUtil

net: add IsMethodIdempotent() to HttpUtil

It goes hand to hand with IsMethodSafe() and is not something
that is specific to the data reduction proxy. So it is better
to keep it in HttpUtil.

BUG=675760
TEST=net_unittests
R=mmenke@chromium.org,bengr@chromium.org

Review-Url: https://codereview.chromium.org/2871913004
Cr-Commit-Position: refs/heads/master@{#470546}
Committed: https://chromium.googlesource.com/chromium/src/+/4f4a5a7103aa313f038ce2990cbdad50ae2ef9c1

[tfarina, 2017-05-09 14:38:42]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 14:39:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 14:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 14:48:01]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tfarina, 2017-05-09 15:34:55]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 15:35:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-09 15:52:49]

net/ LGTM

https://codereview.chromium.org/2871913004/diff/20001/net/http/http_util.h
File net/http/http_util.h (right):

https://codereview.chromium.org/2871913004/diff/20001/net/http/http_util.h#ne...
net/http/http_util.h:81: // Returns true if the request method is idempotent.
nit:  Reference RFC?  (4.2.2 of RFC 7231)

[tfarina, 2017-05-09 16:50:37]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[tfarina, 2017-05-09 16:50:39]

https://codereview.chromium.org/2871913004/diff/20001/net/http/http_util.h
File net/http/http_util.h (right):

https://codereview.chromium.org/2871913004/diff/20001/net/http/http_util.h#ne...
net/http/http_util.h:81: // Returns true if the request method is idempotent.
On 2017/05/09 15:52:49, mmenke wrote:
> nit:  Reference RFC?  (4.2.2 of RFC 7231)

Done.

[commit-bot: I haz the power, 2017-05-09 16:51:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 19:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 19:23:27]

Dry run: This issue passed the CQ dry run.

[bengr, 2017-05-09 21:52:03]

lgtm

[tfarina, 2017-05-09 22:07:56]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2017-05-09 22:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2871913004/#ps40001
(title: "RFC")

[commit-bot: I haz the power, 2017-05-09 22:09:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:12:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[tfarina, 2017-05-10 02:04:33]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:06:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:08:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[tfarina, 2017-05-10 12:58:14]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:58:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 13:03:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494421094796160,
"parent_rev": "1a836b87acc251d1d74c1c54b11b9ac44a7bacd0", "commit_rev":
"4f4a5a7103aa313f038ce2990cbdad50ae2ef9c1"}

[commit-bot: I haz the power, 2017-05-10 13:03:17]

Description was changed from

==========
net: add IsMethodIdempotent() to HttpUtil

It goes hand to hand with IsMethodSafe() and is not something
that is specific to the data reduction proxy. So it is better
to keep it in HttpUtil.

BUG=675760
TEST=net_unittests
R=mmenke@chromium.org,bengr@chromium.org
==========

to

==========
net: add IsMethodIdempotent() to HttpUtil

It goes hand to hand with IsMethodSafe() and is not something
that is specific to the data reduction proxy. So it is better
to keep it in HttpUtil.

BUG=675760
TEST=net_unittests
R=mmenke@chromium.org,bengr@chromium.org

Review-Url: https://codereview.chromium.org/2871913004
Cr-Commit-Position: refs/heads/master@{#470546}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f4a5a7103aa313f038ce2990cbd...
==========

[commit-bot: I haz the power, 2017-05-10 13:03:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4f4a5a7103aa313f038ce2990cbd...