components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 2871913004: net: add IsMethodIdempotent() to HttpUtil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 2871913004: net: add IsMethodIdempotent() to HttpUtil (Closed)

Patch Set: RFC Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index f083a5bd8dd016e33e54f4ad0b188a06379ecee2..ef62c610e40e110da159ce088cb1b612835ecbb2 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -25,7 +25,6 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h"

-#include "components/data_reduction_proxy/core/common/data_reduction_proxy_util.h"

#include "net/base/completion_callback.h"

#include "net/base/host_port_pair.h"

#include "net/base/load_flags.h"

@@ -34,6 +33,7 @@

#include "net/base/proxy_delegate.h"

#include "net/http/http_response_headers.h"

#include "net/http/http_transaction_test_util.h"

+#include "net/http/http_util.h"

#include "net/proxy/proxy_server.h"

#include "net/proxy/proxy_service.h"

#include "net/socket/socket_test_util.h"

@@ -346,7 +346,7 @@ TEST_F(DataReductionProxyProtocolTest, TestIdempotency) {

TRAFFIC_ANNOTATION_FOR_TESTS));

request->set_method(tests[i].method);

EXPECT_EQ(tests[i].expected_result,

- util::IsMethodIdempotent(request->method()));

+ net::HttpUtil::IsMethodIdempotent(request->method()));

}