Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2871893002: color: Ensure solid color IOSurface layers are sRGB (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, alemate+watch_chromium.org, creis+watch_chromium.org, oshima+watch_chromium.org, Ian Vollick, jam, nasko+codewatch_chromium.org, achuith+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, mac-reviews_chromium.org, danakj+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Ensure solid color IOSurface layers are sRGB The IOSurfaces creatd for solid color layers keep the default color space that they were assigned when they were created. This should be sRGB during color correct rendering. In order to check the color correct rendering status when creating an IOSurface, we need to pull the flag out of cc/base/ and into ui/gfx/, so this patch touches lots of files. The end-game for this patch is in crbug.com/254361, where we will hopefully be able to delete base::mac::GetSystemColorSpace(). BUG=719893 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2871893002 Cr-Commit-Position: refs/heads/master@{#470651} Committed: https://chromium.googlesource.com/chromium/src/+/08d4c3723567efd356243bcc1ba3d579660a4d21

Patch Set 1 #

Patch Set 2 : Fix after tests #

Patch Set 3 : Fix up deps #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -24 lines) Patch
M cc/base/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/display/mac/screen_mac.mm View 1 3 chunks +6 lines, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 2 4 chunks +18 lines, -2 lines 2 comments Download
M ui/gfx/mac/io_surface.cc View 1 4 chunks +20 lines, -10 lines 2 comments Download
M ui/gfx/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (16 generated)
ccameron
ptal avi@ for content/OWNERship and Mac-iness achuithb@ for chrome/browser/chromeos/login/ OWNERship
3 years, 7 months ago (2017-05-09 11:23:41 UTC) #11
Avi (use Gerrit)
LGTM for everything except the GN files. Can you find an expert there? That looks ...
3 years, 7 months ago (2017-05-09 14:53:22 UTC) #14
ccameron
+thakis, how do you feel about the DEPS change (as a ui/ OWNER). -achuith (cause ...
3 years, 7 months ago (2017-05-09 16:18:25 UTC) #16
Nico
https://codereview.chromium.org/2871893002/diff/40001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (right): https://codereview.chromium.org/2871893002/diff/40001/ui/gfx/BUILD.gn#newcode553 ui/gfx/BUILD.gn:553: "switches.h", These aren't generated or anything -- is the ...
3 years, 7 months ago (2017-05-09 21:41:11 UTC) #17
ccameron
https://codereview.chromium.org/2871893002/diff/40001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (right): https://codereview.chromium.org/2871893002/diff/40001/ui/gfx/BUILD.gn#newcode553 ui/gfx/BUILD.gn:553: "switches.h", On 2017/05/09 21:41:11, Nico wrote: > These aren't ...
3 years, 7 months ago (2017-05-10 10:19:31 UTC) #18
Nico
Ah, thanks for explaining (and for missing this, I thought I saw only one dep ...
3 years, 7 months ago (2017-05-10 15:40:54 UTC) #19
ccameron
Thanks!
3 years, 7 months ago (2017-05-10 15:44:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871893002/40001
3 years, 7 months ago (2017-05-10 15:45:05 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 18:31:22 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/08d4c3723567efd356243bcc1ba3...

Powered by Google App Engine
This is Rietveld 408576698