Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2871863003: [arm] Print address for load literal instructions. (Closed)

Created:
3 years, 7 months ago by georgia.kouveli
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Print address for load literal instructions. BUG= Review-Url: https://codereview.chromium.org/2871863003 Cr-Commit-Position: refs/heads/master@{#45297} Committed: https://chromium.googlesource.com/v8/v8/+/9171d91c234e996df7ada5194d41c7c98ec2927e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M src/arm/disasm-arm.cc View 2 chunks +32 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
georgia.kouveli
3 years, 7 months ago (2017-05-09 10:41:48 UTC) #2
georgia.kouveli
Any comments?
3 years, 7 months ago (2017-05-15 09:58:08 UTC) #3
Benedikt Meurer
lgtm
3 years, 7 months ago (2017-05-15 10:30:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871863003/1
3 years, 7 months ago (2017-05-15 10:30:21 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 11:00:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9171d91c234e996df7ada5194d41c7c98ec...

Powered by Google App Engine
This is Rietveld 408576698