Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2871813002: Converts remaining usage of WmLayoutManager to aura::LayoutManager (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts remaining usage of WmLayoutManager to aura::LayoutManager Yay! BUG=687657 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2871813002 Cr-Commit-Position: refs/heads/master@{#470233} Committed: https://chromium.googlesource.com/chromium/src/+/97f9a74388f0a4ef84ac44a9e811dbb106c35275

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -438 lines) Patch
M ash/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/aura/aura_layout_manager_adapter.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/aura/aura_layout_manager_adapter.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M ash/keyboard/keyboard_observer_register.h View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/keyboard/keyboard_observer_register.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 8 chunks +23 lines, -31 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 8 chunks +11 lines, -11 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_observer.h View 2 chunks +5 lines, -1 line 0 comments Download
M ash/shell_port.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell_port.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/system/status_area_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_layout_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/lock_layout_manager.h View 3 chunks +10 lines, -9 lines 0 comments Download
M ash/wm/lock_layout_manager.cc View 4 chunks +23 lines, -20 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/root_window_layout_manager.h View 2 chunks +10 lines, -9 lines 0 comments Download
M ash/wm/root_window_layout_manager.cc View 1 3 chunks +11 lines, -11 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.h View 4 chunks +15 lines, -14 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 13 chunks +44 lines, -43 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/window_positioning_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/wm_snap_to_pixel_layout_manager.h View 1 chunk +9 lines, -8 lines 0 comments Download
M ash/wm/wm_snap_to_pixel_layout_manager.cc View 3 chunks +19 lines, -19 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D ash/wm_layout_manager.h View 1 chunk +0 lines, -55 lines 0 comments Download
M ash/wm_window.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/wm_window.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 7 months ago (2017-05-09 00:06:24 UTC) #1
msw
lgtm
3 years, 7 months ago (2017-05-09 00:25:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871813002/20001
3 years, 7 months ago (2017-05-09 01:18:07 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 05:14:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97f9a74388f0a4ef84ac44a9e811...

Powered by Google App Engine
This is Rietveld 408576698