Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: ash/wm/wm_snap_to_pixel_layout_manager.cc

Issue 2871813002: Converts remaining usage of WmLayoutManager to aura::LayoutManager (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/wm/wm_snap_to_pixel_layout_manager.h ('k') | ash/wm/workspace/workspace_layout_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/wm_snap_to_pixel_layout_manager.h" 5 #include "ash/wm/wm_snap_to_pixel_layout_manager.h"
6 6
7 #include "ash/public/cpp/shell_window_ids.h" 7 #include "ash/public/cpp/shell_window_ids.h"
8 #include "ash/wm/window_properties.h" 8 #include "ash/wm/window_properties.h"
9 #include "ash/wm_window.h" 9 #include "ash/wm/window_util.h"
10 #include "base/memory/ptr_util.h"
11 #include "ui/aura/window.h" 10 #include "ui/aura/window.h"
12 11
13 namespace ash { 12 namespace ash {
14 namespace wm { 13 namespace wm {
15 14
16 WmSnapToPixelLayoutManager::WmSnapToPixelLayoutManager() {} 15 WmSnapToPixelLayoutManager::WmSnapToPixelLayoutManager() {}
17 16
18 WmSnapToPixelLayoutManager::~WmSnapToPixelLayoutManager() {} 17 WmSnapToPixelLayoutManager::~WmSnapToPixelLayoutManager() {}
19 18
20 // static 19 // static
21 void WmSnapToPixelLayoutManager::InstallOnContainers(WmWindow* window) { 20 void WmSnapToPixelLayoutManager::InstallOnContainers(aura::Window* window) {
22 for (WmWindow* child : window->GetChildren()) { 21 for (aura::Window* child : window->children()) {
23 if (child->aura_window()->id() < kShellWindowId_Min || 22 if (child->id() < kShellWindowId_Min ||
24 child->aura_window()->id() > kShellWindowId_Max) // not a container 23 child->id() > kShellWindowId_Max) // not a container
25 continue; 24 continue;
26 if (child->aura_window()->GetProperty(kSnapChildrenToPixelBoundary)) { 25 if (child->GetProperty(kSnapChildrenToPixelBoundary)) {
27 if (!child->GetLayoutManager() && !child->aura_window()->layout_manager()) 26 if (!child->layout_manager())
28 child->SetLayoutManager(base::MakeUnique<WmSnapToPixelLayoutManager>()); 27 child->SetLayoutManager(new WmSnapToPixelLayoutManager());
29 } else { 28 } else {
30 InstallOnContainers(child); 29 InstallOnContainers(child);
31 } 30 }
32 } 31 }
33 } 32 }
34 33
35 void WmSnapToPixelLayoutManager::OnWindowResized() {} 34 void WmSnapToPixelLayoutManager::OnWindowResized() {}
36 35
37 void WmSnapToPixelLayoutManager::OnWindowAddedToLayout(WmWindow* child) {} 36 void WmSnapToPixelLayoutManager::OnWindowAddedToLayout(aura::Window* child) {}
38 37
39 void WmSnapToPixelLayoutManager::OnWillRemoveWindowFromLayout(WmWindow* child) { 38 void WmSnapToPixelLayoutManager::OnWillRemoveWindowFromLayout(
40 } 39 aura::Window* child) {}
41 40
42 void WmSnapToPixelLayoutManager::OnWindowRemovedFromLayout(WmWindow* child) {} 41 void WmSnapToPixelLayoutManager::OnWindowRemovedFromLayout(
42 aura::Window* child) {}
43 43
44 void WmSnapToPixelLayoutManager::OnChildWindowVisibilityChanged(WmWindow* child, 44 void WmSnapToPixelLayoutManager::OnChildWindowVisibilityChanged(
45 bool visibile) { 45 aura::Window* child,
46 } 46 bool visibile) {}
47 47
48 void WmSnapToPixelLayoutManager::SetChildBounds( 48 void WmSnapToPixelLayoutManager::SetChildBounds(
49 WmWindow* child, 49 aura::Window* child,
50 const gfx::Rect& requested_bounds) { 50 const gfx::Rect& requested_bounds) {
51 child->SetBoundsDirect(requested_bounds); 51 SetChildBoundsDirect(child, requested_bounds);
52 child->SnapToPixelBoundaryIfNecessary(); 52 wm::SnapWindowToPixelBoundary(child);
53 } 53 }
54 54
55 } // namespace wm 55 } // namespace wm
56 } // namespace ash 56 } // namespace ash
OLDNEW
« no previous file with comments | « ash/wm/wm_snap_to_pixel_layout_manager.h ('k') | ash/wm/workspace/workspace_layout_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698