Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2871793002: Revert of Move nested classes in ComputedStyleBase outside. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
nainar
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move nested classes in ComputedStyleBase outside. (patchset #1 id:1 of https://codereview.chromium.org/2869613002/ ) Reason for revert: Did not decrease binary size. Original issue's description: > Move nested classes in ComputedStyleBase outside. > > Currently, groups such as StyleSurroundData are stored as nested classes > in ComputedStyleBase. It is suspected that this is causing an increase > in binary size. In an atttempt to restore the binary size to its > original value, we move the nested classes outside of ComputedStyleBase. > If this succeeds, we will put these classes in a "detail" namespace to > discourage their use externally. > > Diff of generated files: > https://gist.github.com/darrnshn/7d475a02af6f5d57b4a1622721111cba/revisions > > BUG=718888 > > Review-Url: https://codereview.chromium.org/2869613002 > Cr-Commit-Position: refs/heads/master@{#469911} > Committed: https://chromium.googlesource.com/chromium/src/+/a0fc01a3bcb06cac6e10e6eaf2930b1a0fdb73cc TBR=nainar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718888 Review-Url: https://codereview.chromium.org/2871793002 Cr-Commit-Position: refs/heads/master@{#470150} Committed: https://chromium.googlesource.com/chromium/src/+/73b8f7ed8d1105af3d39563f30a2771aee24923f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
shend
Created Revert of Move nested classes in ComputedStyleBase outside.
3 years, 7 months ago (2017-05-08 22:19:03 UTC) #1
nainar
rs lgtm
3 years, 7 months ago (2017-05-08 23:29:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871793002/1
3 years, 7 months ago (2017-05-08 23:47:59 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 00:00:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73b8f7ed8d1105af3d39563f30a2...

Powered by Google App Engine
This is Rietveld 408576698