Chromium Code Reviews
DescriptionRevert of Move nested classes in ComputedStyleBase outside. (patchset #1 id:1 of https://codereview.chromium.org/2869613002/ )
Reason for revert:
Did not decrease binary size.
Original issue's description:
> Move nested classes in ComputedStyleBase outside.
>
> Currently, groups such as StyleSurroundData are stored as nested classes
> in ComputedStyleBase. It is suspected that this is causing an increase
> in binary size. In an atttempt to restore the binary size to its
> original value, we move the nested classes outside of ComputedStyleBase.
> If this succeeds, we will put these classes in a "detail" namespace to
> discourage their use externally.
>
> Diff of generated files:
> https://gist.github.com/darrnshn/7d475a02af6f5d57b4a1622721111cba/revisions
>
> BUG=718888
>
> Review-Url: https://codereview.chromium.org/2869613002
> Cr-Commit-Position: refs/heads/master@{#469911}
> Committed: https://chromium.googlesource.com/chromium/src/+/a0fc01a3bcb06cac6e10e6eaf2930b1a0fdb73cc
TBR=nainar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718888
Review-Url: https://codereview.chromium.org/2871793002
Cr-Commit-Position: refs/heads/master@{#470150}
Committed: https://chromium.googlesource.com/chromium/src/+/73b8f7ed8d1105af3d39563f30a2771aee24923f
Patch Set 1 #
Messages
Total messages: 11 (7 generated)
|
|||||||||||||||||||