Move nested classes in ComputedStyleBase outside.

Move nested classes in ComputedStyleBase outside.

Currently, groups such as StyleSurroundData are stored as nested classes
in ComputedStyleBase. It is suspected that this is causing an increase
in binary size. In an atttempt to restore the binary size to its
original value, we move the nested classes outside of ComputedStyleBase.
If this succeeds, we will put these classes in a "detail" namespace to
discourage their use externally.

Diff of generated files:
https://gist.github.com/darrnshn/7d475a02af6f5d57b4a1622721111cba/revisions

BUG=718888
Review-Url: https://codereview.chromium.org/2869613002
Cr-Commit-Position: refs/heads/master@{#469911}
Committed: https://chromium.googlesource.com/chromium/src/+/a0fc01a3bcb06cac6e10e6eaf2930b1a0fdb73cc

[shend, 2017-05-07 23:12:48]

Description was changed from

==========
Move nested classes in ComputedStyleBase outside.

Currently, groups such as StyleSurroundData are stored as nested classes
in ComputedStyleBase. It is suspected that this is causing an increase
in binary size. In an atttempt to restore the binary size to its
original value, we move the nested classes outside of ComputedStyleBase.
If this succeeds, we will put these classes in a "detail" namespace to
discourage their use externally.

BUG=718888
==========

to

==========
Move nested classes in ComputedStyleBase outside.

Currently, groups such as StyleSurroundData are stored as nested classes
in ComputedStyleBase. It is suspected that this is causing an increase
in binary size. In an atttempt to restore the binary size to its
original value, we move the nested classes outside of ComputedStyleBase.
If this succeeds, we will put these classes in a "detail" namespace to
discourage their use externally.

Diff of generated files:
https://gist.github.com/darrnshn/7d475a02af6f5d57b4a1622721111cba/revisions

BUG=718888
==========

[shend, 2017-05-07 23:12:56]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-07 23:12:57]

Hi Naina, PTAL

[shend, 2017-05-07 23:13:00]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-07 23:13:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-07 23:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 23:31:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-08 00:06:36]

lgtm - but you have bots failing up and down the seaboard..

[shend, 2017-05-08 00:17:33]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-08 00:17:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 01:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 01:46:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-05-08 02:57:41]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-08 02:57:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 04:14:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 04:14:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-05-08 05:14:30]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-08 05:14:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 07:11:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494220470467460, "parent_rev":
"3a0342b256ebc20b201f435f10dc61105c7515df", "commit_rev":
"a0fc01a3bcb06cac6e10e6eaf2930b1a0fdb73cc"}

[commit-bot: I haz the power, 2017-05-08 07:12:28]

Description was changed from

==========
Move nested classes in ComputedStyleBase outside.

Currently, groups such as StyleSurroundData are stored as nested classes
in ComputedStyleBase. It is suspected that this is causing an increase
in binary size. In an atttempt to restore the binary size to its
original value, we move the nested classes outside of ComputedStyleBase.
If this succeeds, we will put these classes in a "detail" namespace to
discourage their use externally.

Diff of generated files:
https://gist.github.com/darrnshn/7d475a02af6f5d57b4a1622721111cba/revisions

BUG=718888
==========

to

==========
Move nested classes in ComputedStyleBase outside.

Currently, groups such as StyleSurroundData are stored as nested classes
in ComputedStyleBase. It is suspected that this is causing an increase
in binary size. In an atttempt to restore the binary size to its
original value, we move the nested classes outside of ComputedStyleBase.
If this succeeds, we will put these classes in a "detail" namespace to
discourage their use externally.

Diff of generated files:
https://gist.github.com/darrnshn/7d475a02af6f5d57b4a1622721111cba/revisions

BUG=718888

Review-Url: https://codereview.chromium.org/2869613002
Cr-Commit-Position: refs/heads/master@{#469911}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0fc01a3bcb06cac6e10e6eaf293...
==========

[commit-bot: I haz the power, 2017-05-08 07:12:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0fc01a3bcb06cac6e10e6eaf293...

[shend, 2017-05-08 22:19:02]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2871793002/ by shend@chromium.org.

The reason for reverting is: Did not decrease binary size..