Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2871723002: Revert of Create CSRSS Lockdown feature for finching (Closed)

Created:
3 years, 7 months ago by vmiura
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create CSRSS Lockdown feature for finching (patchset #2 id:20001 of https://codereview.chromium.org/2862563004/ ) Reason for revert: This change coincides with our Win 10 GPU bots starting to fail all Telemetry based tests. BUG=719547 Original issue's description: > This creates a feature "EnableCsrssLockdown" so that this capability can be finched. > > BUG=464430 > > Review-Url: https://codereview.chromium.org/2862563004 > Cr-Commit-Position: refs/heads/master@{#469712} > Committed: https://chromium.googlesource.com/chromium/src/+/1290a798ea209beefb9c00e8836aa91e0cf8b87f TBR=wfh@chromium.org,asvitkine@chromium.org,liamjm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=464430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M content/common/sandbox_win.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vmiura
Created Revert of Create CSRSS Lockdown feature for finching
3 years, 7 months ago (2017-05-08 19:20:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871723002/1
3 years, 7 months ago (2017-05-08 19:21:28 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/421127)
3 years, 7 months ago (2017-05-08 21:28:30 UTC) #5
vmiura
3 years, 7 months ago (2017-05-08 21:42:50 UTC) #7
Message was sent while issue was closed.
On 2017/05/08 21:28:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Already landed in https://codereview.chromium.org/2867103003

Powered by Google App Engine
This is Rietveld 408576698