Create CSRSS Lockdown feature for finching

This creates a feature "EnableCsrssLockdown" so that this capability can be finched.

BUG=464430
Review-Url: https://codereview.chromium.org/2862563004
Cr-Commit-Position: refs/heads/master@{#469712}
Committed: https://chromium.googlesource.com/chromium/src/+/1290a798ea209beefb9c00e8836aa91e0cf8b87f

[liamjm (20p), 2017-05-03 23:00:35]

Description was changed from

==========
fixed include in wrong file


Create CSRSS Lockdown feature

BUG=
==========

to

==========
This creates a feature "EnableCsrssLockdown" so that this capability can be
finched.

BUG=464430
==========

[liamjm (20p), 2017-05-03 23:00:35]

liamjm@chromium.org changed reviewers:
+ wfh@google.com

[liamjm (20p), 2017-05-03 23:01:54]

liamjm@chromium.org changed reviewers:
+ wfh@chromium.org
- wfh@google.com

[Will Harris, 2017-05-03 23:04:42]

lgtm

[liamjm (20p), 2017-05-03 23:21:20]

liamjm@chromium.org changed reviewers:
+ asvitkine@chromium.org

[liamjm (20p), 2017-05-03 23:21:20]

asvitkine@chromium.org: Please review changes in
testing/variations/fieldtrial_testing_config.json

[Alexei Svitkine (slow), 2017-05-04 15:04:46]

https://codereview.chromium.org/2862563004/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2862563004/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:839: "name": "Enabled"
You're missing an "enable_features" entry here.

[liamjm (20p), 2017-05-05 15:51:29]

On 2017/05/04 15:04:46, Alexei Svitkine (slow) wrote:
>
https://codereview.chromium.org/2862563004/diff/1/testing/variations/fieldtri...
> File testing/variations/fieldtrial_testing_config.json (right):
> 
>
https://codereview.chromium.org/2862563004/diff/1/testing/variations/fieldtri...
> testing/variations/fieldtrial_testing_config.json:839: "name": "Enabled"
> You're missing an "enable_features" entry here.

Good catch. Thanks.

PTAL.

[Alexei Svitkine (slow), 2017-05-05 16:31:35]

lgtm

[liamjm (20p), 2017-05-05 16:49:15]

The CQ bit was checked by liamjm@chromium.org

[liamjm (20p), 2017-05-05 16:49:15]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2862563004/#ps20001
(title: "add enable_features to EnableCsrssLockdown 
testing/variations/fieldtrial_testing_config.json")

[commit-bot: I haz the power, 2017-05-05 16:49:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:51:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494002955080800,
"parent_rev": "b98530c5ffde8307a9a346797cf3561ca51e1d5b", "commit_rev":
"1290a798ea209beefb9c00e8836aa91e0cf8b87f"}

[commit-bot: I haz the power, 2017-05-05 17:51:33]

Description was changed from

==========
This creates a feature "EnableCsrssLockdown" so that this capability can be
finched.

BUG=464430
==========

to

==========
This creates a feature "EnableCsrssLockdown" so that this capability can be
finched.

BUG=464430

Review-Url: https://codereview.chromium.org/2862563004
Cr-Commit-Position: refs/heads/master@{#469712}
Committed:
https://chromium.googlesource.com/chromium/src/+/1290a798ea209beefb9c00e8836a...
==========

[commit-bot: I haz the power, 2017-05-05 17:51:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1290a798ea209beefb9c00e8836a...

[vmiura, 2017-05-08 19:20:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2871723002/ by vmiura@chromium.org.

The reason for reverting is: This change coincides with our Win 10 GPU bots
starting to fail all Telemetry based tests.

BUG=719547.

[emircan, 2017-05-08 19:28:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2867103003/ by emircan@chromium.org.

The reason for reverting is: Speculative revert to fix the failing webrtc Win10
bots. The error output is:
[4612:3372:0507/153232.151:ERROR:target_services.cc(58)] Failed to find CSR Port
heap handle 
https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester.