Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 2867103003: Revert of Create CSRSS Lockdown feature for finching (Closed)

Created:
3 years, 7 months ago by emircan
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create CSRSS Lockdown feature for finching (patchset #2 id:20001 of https://codereview.chromium.org/2862563004/ ) Reason for revert: Speculative revert to fix the failing webrtc Win10 bots. The error output is: [4612:3372:0507/153232.151:ERROR:target_services.cc(58)] Failed to find CSR Port heap handle https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester Original issue's description: > This creates a feature "EnableCsrssLockdown" so that this capability can be finched. > > BUG=464430 > > Review-Url: https://codereview.chromium.org/2862563004 > Cr-Commit-Position: refs/heads/master@{#469712} > Committed: https://chromium.googlesource.com/chromium/src/+/1290a798ea209beefb9c00e8836aa91e0cf8b87f TBR=wfh@chromium.org,asvitkine@chromium.org,liamjm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=464430 Review-Url: https://codereview.chromium.org/2867103003 Cr-Commit-Position: refs/heads/master@{#470121} Committed: https://chromium.googlesource.com/chromium/src/+/7f48bb7b7fccc67eeb83d7e660893be03ae2f4ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M content/common/sandbox_win.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
emircan
Created Revert of Create CSRSS Lockdown feature for finching
3 years, 7 months ago (2017-05-08 19:28:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867103003/1
3 years, 7 months ago (2017-05-08 19:30:06 UTC) #3
Will Harris
lgtm
3 years, 7 months ago (2017-05-08 19:30:56 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:04:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f48bb7b7fccc67eeb83d7e66089...

Powered by Google App Engine
This is Rietveld 408576698