Remove webContents check when download starts

Remove webContents check when download starts

When download starts, Chrome currently checks for the webcontents to show notifications.
However, download notification shouldn't be tied to the WebContents.
We only need to check whether the webContents is for an empty tab and need to be closed.

BUG=717077
Review-Url: https://codereview.chromium.org/2871663004
Cr-Commit-Position: refs/heads/master@{#470619}
Committed: https://chromium.googlesource.com/chromium/src/+/5130c874ad09faee6fe043cd502a2c1ff07af226

[qinmin, 2017-05-08 21:30:39]

qinmin@chromium.org changed reviewers:
+ dtrainor@chromium.org

[qinmin, 2017-05-08 21:30:40]

PTAL

[qinmin, 2017-05-08 21:35:28]

The CQ bit was checked by qinmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:36:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 00:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 00:24:23]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-05-09 05:57:09]

lgtm % nits

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
(right):

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:202:
* Close a tab if it is blank.'
Remove ' at the end?

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:214:
Activity activity = tab.getWindowAndroid().getActivity().get();
tab.getTabModelSelector()?  Can we ever host this outside a ChromeActivity?

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:220:
return selector.closeTab(tab);
If this is correct, can we update the javadoc?  Does this function return true
if it closed the tab, or if it was already closed?  This looks like it'll return
true when we actually close the tab, but the javadoc makes me think the
opposite.

[qinmin, 2017-05-10 16:09:03]

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
(right):

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:202:
* Close a tab if it is blank.'
On 2017/05/09 05:57:09, David Trainor-ping if over 24h wrote:
> Remove ' at the end?

Done.

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:214:
Activity activity = tab.getWindowAndroid().getActivity().get();
On 2017/05/09 05:57:09, David Trainor-ping if over 24h wrote:
> tab.getTabModelSelector()?  Can we ever host this outside a ChromeActivity?

Done.

https://codereview.chromium.org/2871663004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:220:
return selector.closeTab(tab);
On 2017/05/09 05:57:09, David Trainor-ping if over 24h wrote:
> If this is correct, can we update the javadoc?  Does this function return true
> if it closed the tab, or if it was already closed?  This looks like it'll
return
> true when we actually close the tab, but the javadoc makes me think the
> opposite.

selector.closeTab() returns true if the tab is found, or false otherwise. Since
the tab is non-null here, not found means we are passing a wrong
TabModelSelector. So this is correct.
However, since the TabModelSelector is retrieved from the tab, so closeTab()
should not return false here. So changed this into an assert.

[qinmin, 2017-05-10 16:09:59]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2017-05-10 16:09:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2871663004/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-05-10 16:10:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:05:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494432599491860,
"parent_rev": "2175cc343dabcbe88f953fbe3bf8ebac824b910e", "commit_rev":
"5130c874ad09faee6fe043cd502a2c1ff07af226"}

[commit-bot: I haz the power, 2017-05-10 17:05:48]

Description was changed from

==========
Remove webContents check when download starts

When download starts, Chrome currently checks for the webcontents to show
notifications.
However, download notification shouldn't be tied to the WebContents.
We only need to check whether the webContents is for an empty tab and need to be
closed.

BUG=717077
==========

to

==========
Remove webContents check when download starts

When download starts, Chrome currently checks for the webcontents to show
notifications.
However, download notification shouldn't be tied to the WebContents.
We only need to check whether the webContents is for an empty tab and need to be
closed.

BUG=717077

Review-Url: https://codereview.chromium.org/2871663004
Cr-Commit-Position: refs/heads/master@{#470619}
Committed:
https://chromium.googlesource.com/chromium/src/+/5130c874ad09faee6fe043cd502a...
==========

[commit-bot: I haz the power, 2017-05-10 17:05:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5130c874ad09faee6fe043cd502a...