Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/browser/android/download/chrome_download_delegate.h

Issue 2871663004: Remove webContents check when download starts (Closed)
Patch Set: nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DOWNLOAD_CHROME_DOWNLOAD_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DOWNLOAD_CHROME_DOWNLOAD_DELEGATE_H_
6 #define CHROME_BROWSER_ANDROID_DOWNLOAD_CHROME_DOWNLOAD_DELEGATE_H_ 6 #define CHROME_BROWSER_ANDROID_DOWNLOAD_CHROME_DOWNLOAD_DELEGATE_H_
7 7
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "content/public/browser/web_contents_user_data.h" 9 #include "content/public/browser/web_contents_user_data.h"
10 10
11 class ChromeDownloadDelegate 11 class ChromeDownloadDelegate
12 : public content::WebContentsUserData<ChromeDownloadDelegate> { 12 : public content::WebContentsUserData<ChromeDownloadDelegate> {
13 public: 13 public:
14 ~ChromeDownloadDelegate() override; 14 ~ChromeDownloadDelegate() override;
15 15
16 // Returns true iff this request resulted in the tab creating the download 16 // Returns true iff this request resulted in the tab creating the download
17 // to close. 17 // to close.
18 static bool EnqueueDownloadManagerRequest(jobject chrome_download_delegate, 18 static bool EnqueueDownloadManagerRequest(jobject chrome_download_delegate,
19 bool overwrite, 19 bool overwrite,
20 jobject download_info); 20 jobject download_info);
21 21
22 void SetJavaRef(JNIEnv*, jobject obj); 22 void SetJavaRef(JNIEnv*, jobject obj);
23 23
24 void OnDownloadStarted(const std::string& filename);
25 void RequestFileAccess(intptr_t callback_id); 24 void RequestFileAccess(intptr_t callback_id);
26 25
27 // TODO(qinmin): consolidate this with the static function above. 26 // TODO(qinmin): consolidate this with the static function above.
28 void EnqueueDownloadManagerRequest(const std::string& url, 27 void EnqueueDownloadManagerRequest(const std::string& url,
29 const std::string& user_agent, 28 const std::string& user_agent,
30 const base::string16& file_name, 29 const base::string16& file_name,
31 const std::string& mime_type, 30 const std::string& mime_type,
32 const std::string& cookie, 31 const std::string& cookie,
33 const std::string& referer); 32 const std::string& referer);
34 33
35 private: 34 private:
36 explicit ChromeDownloadDelegate(content::WebContents* contents); 35 explicit ChromeDownloadDelegate(content::WebContents* contents);
37 friend class content::WebContentsUserData<ChromeDownloadDelegate>; 36 friend class content::WebContentsUserData<ChromeDownloadDelegate>;
38 37
39 // A reference to the Java ChromeDownloadDelegate object. 38 // A reference to the Java ChromeDownloadDelegate object.
40 jobject java_ref_; 39 jobject java_ref_;
41 }; 40 };
42 41
43 bool RegisterChromeDownloadDelegate(JNIEnv* env); 42 bool RegisterChromeDownloadDelegate(JNIEnv* env);
44 43
45 #endif // CHROME_BROWSER_ANDROID_DOWNLOAD_CHROME_DOWNLOAD_DELEGATE_H_ 44 #endif // CHROME_BROWSER_ANDROID_DOWNLOAD_CHROME_DOWNLOAD_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698