Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2871593002: Revert of [test] add --no-harness option to debugger tests. (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
Reviewers:
caitp, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] add --no-harness option to debugger tests. (patchset #1 id:1 of https://codereview.chromium.org/2831083003/ ) Reason for revert: Should define its own NO_HARNESS_PATTERN. See comments. Original issue's description: > [test] add --no-harness option to debugger tests. > > Review-Url: https://codereview.chromium.org/2831083003 > Cr-Commit-Position: refs/heads/master@{#44774} > Committed: https://chromium.googlesource.com/v8/v8/+/43c20d4cc566c68ce0b566cad0ac6fa92bba8eff TBR=caitp@igalia.com,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2871593002 Cr-Commit-Position: refs/heads/master@{#45163} Committed: https://chromium.googlesource.com/v8/v8/+/2d41b5f835c4e310374c657780814cb95373da83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M test/debugger/testcfg.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [test] add --no-harness option to debugger tests.
3 years, 7 months ago (2017-05-08 14:34:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871593002/1
3 years, 7 months ago (2017-05-08 14:34:20 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 15:06:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2d41b5f835c4e310374c657780814cb9537...

Powered by Google App Engine
This is Rietveld 408576698