|
|
Description[test] add --no-harness option to debugger tests.
Review-Url: https://codereview.chromium.org/2831083003
Cr-Commit-Position: refs/heads/master@{#44774}
Committed: https://chromium.googlesource.com/v8/v8/+/43c20d4cc566c68ce0b566cad0ac6fa92bba8eff
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (5 generated)
yangguo@chromium.org changed reviewers: + machenbach@chromium.org
Hi Michael, please take a look. Currently, the "V8 Linux64 - custom snapshot - debug" bot only runs mjsunit tests. It would however also make sense to run debugger and inspector tests. Would that be possible? This change makes it possible to run debugger tests. Inspector tests do not care whether mjsunit.js is bundled in the snapshot, and I'd like to test these as well. Cheers, Yang
LGTM, would be, but I think we need a bunch of more config boilerplate as those need to be isolated in isolation.
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1492777973252370, "parent_rev": "0199018c6facec4b18039f2889c18375b9d812d2", "commit_rev": "43c20d4cc566c68ce0b566cad0ac6fa92bba8eff"}
Message was sent while issue was closed.
Description was changed from ========== [test] add --no-harness option to debugger tests. ========== to ========== [test] add --no-harness option to debugger tests. Review-Url: https://codereview.chromium.org/2831083003 Cr-Commit-Position: refs/heads/master@{#44774} Committed: https://chromium.googlesource.com/v8/v8/+/43c20d4cc566c68ce0b566cad0ac6fa92bb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/43c20d4cc566c68ce0b566cad0ac6fa92bb...
Message was sent while issue was closed.
caitp@igalia.com changed reviewers: + caitp@igalia.com
Message was sent while issue was closed.
https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py File test/debugger/testcfg.py (right): https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py#ne... test/debugger/testcfg.py:54: if not context.no_harness and not NO_HARNESS_PATTERN.search(source): This line throws for me since NO_HARNESS_PATTERN is undefined in this file. It can be fixed by copying that line from the mjsunit testcfg.py
Message was sent while issue was closed.
https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py File test/debugger/testcfg.py (right): https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py#ne... test/debugger/testcfg.py:54: if not context.no_harness and not NO_HARNESS_PATTERN.search(source): On 2017/05/08 13:26:21, caitp wrote: > This line throws for me since NO_HARNESS_PATTERN is undefined in this file. It > can be fixed by copying that line from the mjsunit testcfg.py Yea - the right side isn't covered on our bots. I'd revert this and we should reland it fixed and with other required changes. Why do you even need this locally? Do you try to make it work with custom snapshot? On the bot we only test mjsunit with --no-harness.
Message was sent while issue was closed.
On 2017/05/08 13:34:24, Michael Achenbach wrote: > https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py > File test/debugger/testcfg.py (right): > > https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py#ne... > test/debugger/testcfg.py:54: if not context.no_harness and not > NO_HARNESS_PATTERN.search(source): > On 2017/05/08 13:26:21, caitp wrote: > > This line throws for me since NO_HARNESS_PATTERN is undefined in this file. It > > can be fixed by copying that line from the mjsunit testcfg.py > > Yea - the right side isn't covered on our bots. I'd revert this and we should > reland it fixed and with other required changes. > > Why do you even need this locally? Do you try to make it work with custom > snapshot? On the bot we only test mjsunit with --no-harness. I ran into this with `tools/run-tests.py --gn debugger/debug/es6/debug-promises/promise-all-uncaught`
Message was sent while issue was closed.
On 2017/05/08 14:15:15, caitp wrote: > On 2017/05/08 13:34:24, Michael Achenbach wrote: > > https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py > > File test/debugger/testcfg.py (right): > > > > > https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py#ne... > > test/debugger/testcfg.py:54: if not context.no_harness and not > > NO_HARNESS_PATTERN.search(source): > > On 2017/05/08 13:26:21, caitp wrote: > > > This line throws for me since NO_HARNESS_PATTERN is undefined in this file. > It > > > can be fixed by copying that line from the mjsunit testcfg.py > > > > Yea - the right side isn't covered on our bots. I'd revert this and we should > > reland it fixed and with other required changes. > > > > Why do you even need this locally? Do you try to make it work with custom > > snapshot? On the bot we only test mjsunit with --no-harness. > > I ran into this with `tools/run-tests.py --gn > debugger/debug/es6/debug-promises/promise-all-uncaught` And no, no custom snapshot or anything was used.
Message was sent while issue was closed.
On 2017/05/08 14:15:15, caitp wrote: > On 2017/05/08 13:34:24, Michael Achenbach wrote: > > https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py > > File test/debugger/testcfg.py (right): > > > > > https://codereview.chromium.org/2831083003/diff/1/test/debugger/testcfg.py#ne... > > test/debugger/testcfg.py:54: if not context.no_harness and not > > NO_HARNESS_PATTERN.search(source): > > On 2017/05/08 13:26:21, caitp wrote: > > > This line throws for me since NO_HARNESS_PATTERN is undefined in this file. > It > > > can be fixed by copying that line from the mjsunit testcfg.py > > > > Yea - the right side isn't covered on our bots. I'd revert this and we should > > reland it fixed and with other required changes. > > > > Why do you even need this locally? Do you try to make it work with custom > > snapshot? On the bot we only test mjsunit with --no-harness. > > I ran into this with `tools/run-tests.py --gn > debugger/debug/es6/debug-promises/promise-all-uncaught` IC... looks like python imports the whole mjsunit testcfg.py on top-level. But not for you somehow. I think it shouldn't do it anyways, that it works on the bots is a bug.
Message was sent while issue was closed.
I'll revert this for now as it's unused...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2871593002/ by machenbach@chromium.org. The reason for reverting is: Should define its own NO_HARNESS_PATTERN. See comments..
Message was sent while issue was closed.
FYI: Filed http://crbug.com/v8/6375 for the underlying import problems. |