Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: media/renderers/default_renderer_factory.cc

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Remove ScopedVector from audio/video render related code in media/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/default_renderer_factory.cc
diff --git a/media/renderers/default_renderer_factory.cc b/media/renderers/default_renderer_factory.cc
index 9d61092439cb3419169c5e1d6b9c01b28d577606..2c726b6c25af5d287ca8940b42e47eeb1bbfa3ee 100644
--- a/media/renderers/default_renderer_factory.cc
+++ b/media/renderers/default_renderer_factory.cc
@@ -7,7 +7,6 @@
#include <utility>
#include "base/bind.h"
-#include "base/memory/ptr_util.h"
#include "base/single_thread_task_runner.h"
#include "build/build_config.h"
#include "media/base/decoder_factory.h"
@@ -42,14 +41,15 @@ DefaultRendererFactory::DefaultRendererFactory(
DefaultRendererFactory::~DefaultRendererFactory() {
}
-ScopedVector<AudioDecoder> DefaultRendererFactory::CreateAudioDecoders(
+std::vector<std::unique_ptr<AudioDecoder>>
+DefaultRendererFactory::CreateAudioDecoders(
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) {
// Create our audio decoders and renderer.
- ScopedVector<AudioDecoder> audio_decoders;
+ std::vector<std::unique_ptr<AudioDecoder>> audio_decoders;
#if !defined(MEDIA_DISABLE_FFMPEG)
audio_decoders.push_back(
- new FFmpegAudioDecoder(media_task_runner, media_log_));
+ base::MakeUnique<FFmpegAudioDecoder>(media_task_runner, media_log_));
#endif
// Use an external decoder only if we cannot otherwise decode in the
@@ -60,12 +60,13 @@ ScopedVector<AudioDecoder> DefaultRendererFactory::CreateAudioDecoders(
return audio_decoders;
}
-ScopedVector<VideoDecoder> DefaultRendererFactory::CreateVideoDecoders(
+std::vector<std::unique_ptr<VideoDecoder>>
+DefaultRendererFactory::CreateVideoDecoders(
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
const RequestSurfaceCB& request_surface_cb,
GpuVideoAcceleratorFactories* gpu_factories) {
// Create our video decoders and renderer.
- ScopedVector<VideoDecoder> video_decoders;
+ std::vector<std::unique_ptr<VideoDecoder>> video_decoders;
// Prefer an external decoder since one will only exist if it is hardware
// accelerated.
@@ -79,16 +80,16 @@ ScopedVector<VideoDecoder> DefaultRendererFactory::CreateVideoDecoders(
decoder_factory_->CreateVideoDecoders(media_task_runner, gpu_factories,
&video_decoders);
}
- video_decoders.push_back(
- new GpuVideoDecoder(gpu_factories, request_surface_cb, media_log_));
+ video_decoders.push_back(base::MakeUnique<GpuVideoDecoder>(
+ gpu_factories, request_surface_cb, media_log_));
}
#if !defined(MEDIA_DISABLE_LIBVPX)
- video_decoders.push_back(new VpxVideoDecoder());
+ video_decoders.push_back(base::MakeUnique<VpxVideoDecoder>());
#endif
#if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS)
- video_decoders.push_back(new FFmpegVideoDecoder(media_log_));
+ video_decoders.push_back(base::MakeUnique<FFmpegVideoDecoder>(media_log_));
#endif
return video_decoders;

Powered by Google App Engine
This is Rietveld 408576698