Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: media/renderers/default_renderer_factory.cc

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Remove ScopedVector from audio/video render related code in media/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/renderers/default_renderer_factory.h" 5 #include "media/renderers/default_renderer_factory.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ptr_util.h"
11 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
12 #include "build/build_config.h" 11 #include "build/build_config.h"
13 #include "media/base/decoder_factory.h" 12 #include "media/base/decoder_factory.h"
14 #include "media/base/media_log.h" 13 #include "media/base/media_log.h"
15 #include "media/filters/gpu_video_decoder.h" 14 #include "media/filters/gpu_video_decoder.h"
16 #include "media/renderers/audio_renderer_impl.h" 15 #include "media/renderers/audio_renderer_impl.h"
17 #include "media/renderers/gpu_video_accelerator_factories.h" 16 #include "media/renderers/gpu_video_accelerator_factories.h"
18 #include "media/renderers/renderer_impl.h" 17 #include "media/renderers/renderer_impl.h"
19 #include "media/renderers/video_renderer_impl.h" 18 #include "media/renderers/video_renderer_impl.h"
20 19
(...skipping 14 matching lines...) Expand all
35 MediaLog* media_log, 34 MediaLog* media_log,
36 DecoderFactory* decoder_factory, 35 DecoderFactory* decoder_factory,
37 const GetGpuFactoriesCB& get_gpu_factories_cb) 36 const GetGpuFactoriesCB& get_gpu_factories_cb)
38 : media_log_(media_log), 37 : media_log_(media_log),
39 decoder_factory_(decoder_factory), 38 decoder_factory_(decoder_factory),
40 get_gpu_factories_cb_(get_gpu_factories_cb) {} 39 get_gpu_factories_cb_(get_gpu_factories_cb) {}
41 40
42 DefaultRendererFactory::~DefaultRendererFactory() { 41 DefaultRendererFactory::~DefaultRendererFactory() {
43 } 42 }
44 43
45 ScopedVector<AudioDecoder> DefaultRendererFactory::CreateAudioDecoders( 44 std::vector<std::unique_ptr<AudioDecoder>>
45 DefaultRendererFactory::CreateAudioDecoders(
46 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) { 46 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) {
47 // Create our audio decoders and renderer. 47 // Create our audio decoders and renderer.
48 ScopedVector<AudioDecoder> audio_decoders; 48 std::vector<std::unique_ptr<AudioDecoder>> audio_decoders;
49 49
50 #if !defined(MEDIA_DISABLE_FFMPEG) 50 #if !defined(MEDIA_DISABLE_FFMPEG)
51 audio_decoders.push_back( 51 audio_decoders.push_back(
52 new FFmpegAudioDecoder(media_task_runner, media_log_)); 52 base::MakeUnique<FFmpegAudioDecoder>(media_task_runner, media_log_));
53 #endif 53 #endif
54 54
55 // Use an external decoder only if we cannot otherwise decode in the 55 // Use an external decoder only if we cannot otherwise decode in the
56 // renderer. 56 // renderer.
57 if (decoder_factory_) 57 if (decoder_factory_)
58 decoder_factory_->CreateAudioDecoders(media_task_runner, &audio_decoders); 58 decoder_factory_->CreateAudioDecoders(media_task_runner, &audio_decoders);
59 59
60 return audio_decoders; 60 return audio_decoders;
61 } 61 }
62 62
63 ScopedVector<VideoDecoder> DefaultRendererFactory::CreateVideoDecoders( 63 std::vector<std::unique_ptr<VideoDecoder>>
64 DefaultRendererFactory::CreateVideoDecoders(
64 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 65 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
65 const RequestSurfaceCB& request_surface_cb, 66 const RequestSurfaceCB& request_surface_cb,
66 GpuVideoAcceleratorFactories* gpu_factories) { 67 GpuVideoAcceleratorFactories* gpu_factories) {
67 // Create our video decoders and renderer. 68 // Create our video decoders and renderer.
68 ScopedVector<VideoDecoder> video_decoders; 69 std::vector<std::unique_ptr<VideoDecoder>> video_decoders;
69 70
70 // Prefer an external decoder since one will only exist if it is hardware 71 // Prefer an external decoder since one will only exist if it is hardware
71 // accelerated. 72 // accelerated.
72 if (gpu_factories) { 73 if (gpu_factories) {
73 // |gpu_factories_| requires that its entry points be called on its 74 // |gpu_factories_| requires that its entry points be called on its
74 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the 75 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the
75 // factories, require that their message loops are identical. 76 // factories, require that their message loops are identical.
76 DCHECK(gpu_factories->GetTaskRunner() == media_task_runner.get()); 77 DCHECK(gpu_factories->GetTaskRunner() == media_task_runner.get());
77 78
78 if (decoder_factory_) { 79 if (decoder_factory_) {
79 decoder_factory_->CreateVideoDecoders(media_task_runner, gpu_factories, 80 decoder_factory_->CreateVideoDecoders(media_task_runner, gpu_factories,
80 &video_decoders); 81 &video_decoders);
81 } 82 }
82 video_decoders.push_back( 83 video_decoders.push_back(base::MakeUnique<GpuVideoDecoder>(
83 new GpuVideoDecoder(gpu_factories, request_surface_cb, media_log_)); 84 gpu_factories, request_surface_cb, media_log_));
84 } 85 }
85 86
86 #if !defined(MEDIA_DISABLE_LIBVPX) 87 #if !defined(MEDIA_DISABLE_LIBVPX)
87 video_decoders.push_back(new VpxVideoDecoder()); 88 video_decoders.push_back(base::MakeUnique<VpxVideoDecoder>());
88 #endif 89 #endif
89 90
90 #if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS) 91 #if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS)
91 video_decoders.push_back(new FFmpegVideoDecoder(media_log_)); 92 video_decoders.push_back(base::MakeUnique<FFmpegVideoDecoder>(media_log_));
92 #endif 93 #endif
93 94
94 return video_decoders; 95 return video_decoders;
95 } 96 }
96 97
97 std::unique_ptr<Renderer> DefaultRendererFactory::CreateRenderer( 98 std::unique_ptr<Renderer> DefaultRendererFactory::CreateRenderer(
98 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 99 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
99 const scoped_refptr<base::TaskRunner>& worker_task_runner, 100 const scoped_refptr<base::TaskRunner>& worker_task_runner,
100 AudioRendererSink* audio_renderer_sink, 101 AudioRendererSink* audio_renderer_sink,
101 VideoRendererSink* video_renderer_sink, 102 VideoRendererSink* video_renderer_sink,
(...skipping 27 matching lines...) Expand all
129 base::Bind(&DefaultRendererFactory::CreateVideoDecoders, 130 base::Bind(&DefaultRendererFactory::CreateVideoDecoders,
130 base::Unretained(this), media_task_runner, request_surface_cb, 131 base::Unretained(this), media_task_runner, request_surface_cb,
131 gpu_factories), 132 gpu_factories),
132 true, gpu_factories, media_log_)); 133 true, gpu_factories, media_log_));
133 134
134 return base::MakeUnique<RendererImpl>( 135 return base::MakeUnique<RendererImpl>(
135 media_task_runner, std::move(audio_renderer), std::move(video_renderer)); 136 media_task_runner, std::move(audio_renderer), std::move(video_renderer));
136 } 137 }
137 138
138 } // namespace media 139 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698