Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2871463002: Move StyleRareInheritedData accessors to be inline in ComputedStyle. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleRareInheritedData accessors to be inline in ComputedStyle. Currently, ComputedStyle has getters and setters to some members in StyleRareInheritedData. These getters and setters simply delegate to getters and setters on StyleRareInheritedData. When we generate StyleRareInheritedData, the generator does not generate these getters and setters. Hence, this patch simply moves these accessors to be inline in the getters/setters in ComputedStyle. This is preparation for generating StyleRareInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2871463002 Cr-Commit-Position: refs/heads/master@{#471223} Committed: https://chromium.googlesource.com/chromium/src/+/8ddfef7806bcbedb9582efc385088603b200d2d9

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -128 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 8 chunks +78 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 chunks +10 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 1 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 31 (25 generated)
shend
Hi Bugs, PTAL
3 years, 7 months ago (2017-05-08 06:12:59 UTC) #4
Bugs Nash
lgtm. please add to description *why* we can't have getters and setters on the generated ...
3 years, 7 months ago (2017-05-09 23:55:00 UTC) #7
shend
Updated the CL desc. Hi Eddy, PTAL
3 years, 7 months ago (2017-05-10 00:47:14 UTC) #10
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-11 01:56:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871463002/20001
3 years, 7 months ago (2017-05-12 04:37:58 UTC) #28
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 04:44:18 UTC) #31
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8ddfef7806bcbedb9582efc38508...

Powered by Google App Engine
This is Rietveld 408576698