|
|
DescriptionMove StyleRareInheritedData accessors to be inline in ComputedStyle.
Currently, ComputedStyle has getters and setters to some members in
StyleRareInheritedData. These getters and setters simply delegate to
getters and setters on StyleRareInheritedData. When we generate
StyleRareInheritedData, the generator does not generate these
getters and setters. Hence, this patch simply moves these accessors to
be inline in the getters/setters in ComputedStyle.
This is preparation for generating StyleRareInheritedData.
BUG=628043
Review-Url: https://codereview.chromium.org/2871463002
Cr-Commit-Position: refs/heads/master@{#471223}
Committed: https://chromium.googlesource.com/chromium/src/+/8ddfef7806bcbedb9582efc385088603b200d2d9
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebase #
Messages
Total messages: 31 (25 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + bugsnash@chromium.org
Hi Bugs, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm. please add to description *why* we can't have getters and setters on the generated StyleRareInheritedData https://codereview.chromium.org/2871463002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right): https://codereview.chromium.org/2871463002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/style/ComputedStyle.cpp:1075: (TextFillColor() != other.TextFillColor() || much nicer!
Description was changed from ========== Move StyleRareInheritedData accessors to be inline in ComputedStyle. Currently, ComputedStyle has getters and setters to some members in StyleRareInheritedData. These getters and setters simply delegate to getters and setters on StyleRareInheritedData. When we generate StyleRareInheritedData, the generated StyleRareInheritedData cannot have getters and setters. Hence, this patch simply moves these accessors to be inline in the getters/setters in ComputedStyle. This is preparation for generating StyleRareInheritedData. BUG=628043 ========== to ========== Move StyleRareInheritedData accessors to be inline in ComputedStyle. Currently, ComputedStyle has getters and setters to some members in StyleRareInheritedData. These getters and setters simply delegate to getters and setters on StyleRareInheritedData. When we generate StyleRareInheritedData, the generator does not generate these getters and setters. Hence, this patch simply moves these accessors to be inline in the getters/setters in ComputedStyle. This is preparation for generating StyleRareInheritedData. BUG=628043 ==========
shend@chromium.org changed reviewers: + meade@chromium.org
Updated the CL desc. Hi Eddy, PTAL
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org
The CQ bit was unchecked by shend@chromium.org
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org, bugsnash@chromium.org Link to the patchset: https://codereview.chromium.org/2871463002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494563858051040, "parent_rev": "6fb560e0be6e124a89f10780668c3d150c0340e4", "commit_rev": "8ddfef7806bcbedb9582efc385088603b200d2d9"}
Message was sent while issue was closed.
Description was changed from ========== Move StyleRareInheritedData accessors to be inline in ComputedStyle. Currently, ComputedStyle has getters and setters to some members in StyleRareInheritedData. These getters and setters simply delegate to getters and setters on StyleRareInheritedData. When we generate StyleRareInheritedData, the generator does not generate these getters and setters. Hence, this patch simply moves these accessors to be inline in the getters/setters in ComputedStyle. This is preparation for generating StyleRareInheritedData. BUG=628043 ========== to ========== Move StyleRareInheritedData accessors to be inline in ComputedStyle. Currently, ComputedStyle has getters and setters to some members in StyleRareInheritedData. These getters and setters simply delegate to getters and setters on StyleRareInheritedData. When we generate StyleRareInheritedData, the generator does not generate these getters and setters. Hence, this patch simply moves these accessors to be inline in the getters/setters in ComputedStyle. This is preparation for generating StyleRareInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2871463002 Cr-Commit-Position: refs/heads/master@{#471223} Committed: https://chromium.googlesource.com/chromium/src/+/8ddfef7806bcbedb9582efc38508... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8ddfef7806bcbedb9582efc38508... |