Move StyleRareInheritedData accessors to be inline in ComputedStyle.

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 1054 matching lines @@
           (rare_non_inherited_data_->text_decoration_style_ !=
                other.rare_non_inherited_data_->text_decoration_style_ ||
            rare_non_inherited_data_->text_decoration_color_ !=
                other.rare_non_inherited_data_->text_decoration_color_ ||
            rare_non_inherited_data_->visited_link_text_decoration_color_ !=
                other.rare_non_inherited_data_
                    ->visited_link_text_decoration_color_)) {
         diff.SetTextDecorationOrColorChanged();
       } else {
         if (rare_inherited_data_.Get() != other.rare_inherited_data_.Get() &&
-            (rare_inherited_data_->TextFillColor() !=
-                 other.rare_inherited_data_->TextFillColor() ||
-             rare_inherited_data_->TextStrokeColor() !=
-                 other.rare_inherited_data_->TextStrokeColor() ||
-             rare_inherited_data_->TextEmphasisColor() !=
-                 other.rare_inherited_data_->TextEmphasisColor() ||
-             rare_inherited_data_->VisitedLinkTextFillColor() !=
-                 other.rare_inherited_data_->VisitedLinkTextFillColor() ||
-             rare_inherited_data_->VisitedLinkTextStrokeColor() !=
-                 other.rare_inherited_data_->VisitedLinkTextStrokeColor() ||
-             rare_inherited_data_->VisitedLinkTextEmphasisColor() !=
-                 other.rare_inherited_data_->VisitedLinkTextEmphasisColor() ||
+            (TextFillColor() != other.TextFillColor() ||

[Bugs Nash, 2017/05/09 23:55:00]

much nicer!

+             TextStrokeColor() != other.TextStrokeColor() ||
+             TextEmphasisColor() != other.TextEmphasisColor() ||
+             VisitedLinkTextFillColor() != other.VisitedLinkTextFillColor() ||
+             VisitedLinkTextStrokeColor() !=
+                 other.VisitedLinkTextStrokeColor() ||
+             VisitedLinkTextEmphasisColor() !=
+                 other.VisitedLinkTextEmphasisColor() ||
              rare_inherited_data_->text_emphasis_fill !=
                  other.rare_inherited_data_->text_emphasis_fill ||
              rare_inherited_data_->text_underline_position_ !=
                  other.rare_inherited_data_->text_underline_position_ ||
              rare_inherited_data_->text_decoration_skip_ !=
                  other.rare_inherited_data_->text_decoration_skip_ ||
              rare_inherited_data_->applied_text_decorations !=
                  other.rare_inherited_data_->applied_text_decorations ||
-             rare_inherited_data_->CaretColor() !=
-                 other.rare_inherited_data_->CaretColor() ||
-             rare_inherited_data_->VisitedLinkCaretColor() !=
-                 other.rare_inherited_data_->VisitedLinkCaretColor())) {
+             CaretColor() != CaretColor() ||
+             VisitedLinkCaretColor() != other.VisitedLinkCaretColor())) {
           diff.SetTextDecorationOrColorChanged();
         }
       }
     }
   }
 
   bool has_clip = HasOutOfFlowPosition() && !visual_data_->has_auto_clip;
   bool other_has_clip =
       other.HasOutOfFlowPosition() && !other.visual_data_->has_auto_clip;
   if (has_clip != other_has_clip ||
@@ skipping 1397 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return RoundForImpreciseConversion<int>(fvalue / zoom_factor);
 }
 
 }  // namespace blink