Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2871283002: Run lint on javac output instead of process_java_prebuilt output. (Closed)

Created:
3 years, 7 months ago by F
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Run lint on javac output instead of process_java_prebuilt output. During the process_java_prebuilt step, javac output might be modified by retrolambda. As a result, if lint is run on processed_java_prebuilt output, lint might not give the correct results. This CL makes lint run on javac output instead of process_java_prebuilt output to eliminate this possibility. BUG=642600 Review-Url: https://codereview.chromium.org/2871283002 Cr-Commit-Position: refs/heads/master@{#470673} Committed: https://chromium.googlesource.com/chromium/src/+/f0f89654334792a032ac1f49c3e988f4b87cf2ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/config/android/internal_rules.gni View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
F
Hi Andrew, PTAL. Thanks!
3 years, 7 months ago (2017-05-10 18:05:01 UTC) #4
agrieve
On 2017/05/10 18:05:01, F wrote: > Hi Andrew, PTAL. Thanks! lgtm
3 years, 7 months ago (2017-05-10 18:27:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871283002/1
3 years, 7 months ago (2017-05-10 18:59:01 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 19:44:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0f89654334792a032ac1f49c3e9...

Powered by Google App Engine
This is Rietveld 408576698