Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: build/config/android/internal_rules.gni

Issue 2871283002: Run lint on javac output instead of process_java_prebuilt output. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 813686305c03adcaa679923f6c559c0b866a43ee..e4d7bea509c6df635100b643fed881d9a5596d09 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -2269,6 +2269,7 @@ if (enable_java_templates) {
forward_variables_from(invoker, [ "visibility" ])
public_deps = [
":$_ijar_target_name",
+ ":$_javac_target_name",
]
if (_emma_instrument) {
public_deps += [ ":$_emma_instr_target_name" ]
@@ -2505,7 +2506,10 @@ if (enable_java_templates) {
android_lint("${_template_name}__lint") {
android_manifest = _android_manifest
build_config = _build_config
- jar_path = _jar_path
+
+ # Run lint on javac output.
+ jar_path = "$target_gen_dir/$_compile_java_target.javac.jar"
+
java_files = _java_files
if (_java_files != []) {
java_sources_file = _java_sources_file
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698