|
|
Created:
3 years, 7 months ago by Kunihiko Sakamoto Modified:
3 years, 7 months ago CC:
chromium-reviews, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable preload for module scripts
This patch disables preload for <script type="module">, to prevent
duplicated requests due to credentials mode mismatch. In the long term,
we should teach Preload Scanner about the module script credentials mode
and re-enable preload.
BUG=717525
Review-Url: https://codereview.chromium.org/2871153002
Cr-Commit-Position: refs/heads/master@{#470853}
Committed: https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260accc8dd765d26b
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (12 generated)
Description was changed from ========== Disable preload for module scripts BUG=717525 ========== to ========== Disable preload for module scripts This patch disables preload for <script type="module">, to prevent duplicated requests due to credentials mode mismatch. In the long term, we should teach Preload Scanner about the module script credentials mode and re-enable preload. BUG=717525 ==========
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ksakamoto@chromium.org changed reviewers: + kouhei@chromium.org
https://codereview.chromium.org/2871153002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right): https://codereview.chromium.org/2871153002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:544: // TODO(kouhei): Enable preload for module scripts, with correct Kouhei, would you mind having your name here? :)
Would this happen also for link preload?
kinuko@chromium.org changed reviewers: + kinuko@chromium.org
lgtm. TODO(kouhei) sgtm On 2017/05/10 10:49:14, kinuko wrote: > Would this happen also for link preload? Link rel=preload for module scripts are currently under discussion in https://github.com/whatwg/fetch/issues/486 , which I need to catch up
On 2017/05/10 10:55:38, kouhei (on transit) wrote: > lgtm. TODO(kouhei) sgtm > > On 2017/05/10 10:49:14, kinuko wrote: > > Would this happen also for link preload? > Link rel=preload for module scripts are currently under discussion in > https://github.com/whatwg/fetch/issues/486 , which I need to catch up oh ok, so it's basically not spec'ed (thus not supported). Thanks! (lgtm/2)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494480632608770, "parent_rev": "0ee3f5bbf9158e6883ebe57102496b7543cb3b89", "commit_rev": "32a2d84e17b0b63b284f259260accc8dd765d26b"}
Message was sent while issue was closed.
Description was changed from ========== Disable preload for module scripts This patch disables preload for <script type="module">, to prevent duplicated requests due to credentials mode mismatch. In the long term, we should teach Preload Scanner about the module script credentials mode and re-enable preload. BUG=717525 ========== to ========== Disable preload for module scripts This patch disables preload for <script type="module">, to prevent duplicated requests due to credentials mode mismatch. In the long term, we should teach Preload Scanner about the module script credentials mode and re-enable preload. BUG=717525 Review-Url: https://codereview.chromium.org/2871153002 Cr-Commit-Position: refs/heads/master@{#470853} Committed: https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260ac... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260ac...
Message was sent while issue was closed.
On 2017/05/11 06:54:15, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260ac... Retroactive LGTM |