Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2871153002: Disable preload for module scripts (Closed)

Created:
3 years, 7 months ago by Kunihiko Sakamoto
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable preload for module scripts This patch disables preload for <script type="module">, to prevent duplicated requests due to credentials mode mismatch. In the long term, we should teach Preload Scanner about the module script credentials mode and re-enable preload. BUG=717525 Review-Url: https://codereview.chromium.org/2871153002 Cr-Commit-Position: refs/heads/master@{#470853} Committed: https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260accc8dd765d26b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 21 (12 generated)
Kunihiko Sakamoto
https://codereview.chromium.org/2871153002/diff/1/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right): https://codereview.chromium.org/2871153002/diff/1/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp#newcode544 third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:544: // TODO(kouhei): Enable preload for module scripts, with correct ...
3 years, 7 months ago (2017-05-10 10:07:12 UTC) #5
kinuko
Would this happen also for link preload?
3 years, 7 months ago (2017-05-10 10:49:14 UTC) #6
kouhei (in TOK)
lgtm. TODO(kouhei) sgtm On 2017/05/10 10:49:14, kinuko wrote: > Would this happen also for link ...
3 years, 7 months ago (2017-05-10 10:55:38 UTC) #8
kinuko
On 2017/05/10 10:55:38, kouhei (on transit) wrote: > lgtm. TODO(kouhei) sgtm > > On 2017/05/10 ...
3 years, 7 months ago (2017-05-10 11:02:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871153002/1
3 years, 7 months ago (2017-05-11 01:03:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451113)
3 years, 7 months ago (2017-05-11 03:55:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871153002/1
3 years, 7 months ago (2017-05-11 05:31:22 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260accc8dd765d26b
3 years, 7 months ago (2017-05-11 06:54:15 UTC) #20
Yoav Weiss
3 years, 7 months ago (2017-05-11 09:00:19 UTC) #21
Message was sent while issue was closed.
On 2017/05/11 06:54:15, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/32a2d84e17b0b63b284f259260ac...

Retroactive LGTM

Powered by Google App Engine
This is Rietveld 408576698