Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 2871153002: Disable preload for module scripts (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
index 5c6106355a1ee952024bca5d718f3cad37d19518..6f0aea5a33edf81d3a20054abb7125e0b1a0db66 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
@@ -541,6 +541,10 @@ class TokenPreloadScanner::StartTagScanner {
ScriptLoader::kAllowLegacyTypeInTypeAttribute, script_type)) {
return false;
}
+ // TODO(kouhei): Enable preload for module scripts, with correct
Kunihiko Sakamoto 2017/05/10 10:07:12 Kouhei, would you mind having your name here? :)
+ // credentials mode.
+ if (type_attribute_value_ == "module")
+ return false;
if (ScriptLoader::BlockForNoModule(script_type,
nomodule_attribute_value_)) {
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698