components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h - Issue 2871013002: [subresource_filter] Refactor activation suppression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

Issue 2871013002: [subresource_filter] Refactor activation suppression (Closed)

Patch Set: rebase on #470635 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

index 446296538270edd2d17cbcb930676fe1ef1962b3..ac88d7decf9b1594500d7260bebf19e8c5f57a18 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

@@ -53,11 +53,6 @@ class ContentSubresourceFilterThrottleManager

// first load is disallowed for a given page load.

virtual void OnFirstSubresourceLoadDisallowed() {}

- // Let the delegate have the last word when it comes to activation. It might

- // have a specific whitelist.

- virtual bool ShouldSuppressActivation(

- content::NavigationHandle* navigation_handle);

// Temporary method to help the delegate compute the activation decision.

virtual void WillProcessResponse(

content::NavigationHandle* navigation_handle) {}