Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc

Issue 2871013002: [subresource_filter] Refactor activation suppression (Closed)
Patch Set: rebase on #470635 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
index 1d4161870d7d4e0d65ab092ee9f1fa37dc2349db..a5e011072bd32d91d7b7a92decf885ff1b06ea8b 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
@@ -51,11 +51,6 @@ class ForwardingNavigationThrottle : public content::NavigationThrottle {
} // namespace
-bool ContentSubresourceFilterThrottleManager::Delegate::
- ShouldSuppressActivation(content::NavigationHandle* navigation_handle) {
- return false;
-}
-
ContentSubresourceFilterThrottleManager::
ContentSubresourceFilterThrottleManager(
Delegate* delegate,
@@ -100,8 +95,7 @@ void ContentSubresourceFilterThrottleManager::ReadyToCommitNavigation(
AsyncDocumentSubresourceFilter* filter = throttle->second->filter();
if (!filter || navigation_handle->GetNetErrorCode() != net::OK ||
filter->activation_state().activation_level ==
- ActivationLevel::DISABLED ||
- delegate_->ShouldSuppressActivation(navigation_handle)) {
+ ActivationLevel::DISABLED) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698