Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2871013002: [subresource_filter] Refactor activation suppression (Closed)
Patch Set: rebase on #470635 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
index 468350bc5db809d5508d23a3ec13afc84c6e5ace..7e856982e755f5a489d1c12440472a77a01a678b 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
@@ -126,9 +126,6 @@ void ContentSubresourceFilterDriverFactory::
return;
}
- // TODO(csharrison): The throttle manager also performs this check. Remove
- // this one when the activation decision is sent directly to the throttle
- // manager.
if (client_->ShouldSuppressActivation(navigation_handle)) {
activation_decision_ = ActivationDecision::URL_WHITELISTED;
activation_options_ = Configuration::ActivationOptions();
@@ -227,11 +224,6 @@ void ContentSubresourceFilterDriverFactory::OnFirstSubresourceLoadDisallowed() {
ActivationLevel::ENABLED);
}
-bool ContentSubresourceFilterDriverFactory::ShouldSuppressActivation(
- content::NavigationHandle* navigation_handle) {
- return client_->ShouldSuppressActivation(navigation_handle);
-}
-
void ContentSubresourceFilterDriverFactory::DidStartNavigation(
content::NavigationHandle* navigation_handle) {
if (navigation_handle->IsInMainFrame() &&

Powered by Google App Engine
This is Rietveld 408576698