chromeos: Adds --mus flag

chromeos: Adds --mus flag

This changes the mus flag to a multi-value setting the changes between no switch (the default) --mus and --mash

BUG=none
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2870893003
Cr-Commit-Position: refs/heads/master@{#471859}
Committed: https://chromium.googlesource.com/chromium/src/+/527bea550106b69c89b1ddbd026498e5396c6ec0

[James Cook, 2017-05-09 21:54:21]

LGTM

[sky, 2017-05-09 22:13:01]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-09 22:14:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:16:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:16:37]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[James Cook, 2017-05-11 23:14:48]

I think there was an infra outage when you tried to land this. I'm going to
stick it back in CQ.

[James Cook, 2017-05-11 23:14:54]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-05-11 23:15:49]

Oops, nope, those look like real failures. Nevermind.

[commit-bot: I haz the power, 2017-05-11 23:15:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-11 23:16:37]

The CQ bit was unchecked by jamescook@chromium.org

[sky, 2017-05-15 13:51:59]

Description was changed from

==========
chromeos: Adds --mus flag

BUG=none
TEST=none
R=jamescook@chromium.org
==========

to

==========
chromeos: Adds --mus flag

This changes the mus flag to a multi-value setting the changes between no switch
(the default) --mus and --mash

BUG=none
TEST=none
R=jamescook@chromium.org
==========

[sky, 2017-05-15 13:52:26]

Ok, updated to use a multi value type and updated the xml file that was causing
the failure.

[sky, 2017-05-15 13:52:38]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 13:52:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 14:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:49:17]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-05-15 16:49:18]

LGTM with language nit

https://codereview.chromium.org/2870893003/diff/40001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2870893003/diff/40001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:923: "Mash (Chrome and ash in separate
services)";
How about:

Mash (UI, Chrome and ash in separate services)

Mus (UI in separate service, Chrome and ash in same service)

optionally: s/service/process/

I think we should emphasize that the point of these flags is the UI service
running out of process.

[sky, 2017-05-15 17:53:39]

https://codereview.chromium.org/2870893003/diff/40001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2870893003/diff/40001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:923: "Mash (Chrome and ash in separate
services)";
On 2017/05/15 16:49:18, James Cook wrote:
> How about:
> 
> Mash (UI, Chrome and ash in separate services)
> 
> Mus (UI in separate service, Chrome and ash in same service)

Done.

> optionally: s/service/process/
> 
> I think we should emphasize that the point of these flags is the UI service
> running out of process.

I didn't change service to process as the important thing is they are separate
services. This may matter if we play with what processes the services actually
live in.

[sky, 2017-05-15 17:55:21]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-15 17:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2870893003/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2017-05-15 17:56:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:15:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494870921039620,
"parent_rev": "2ed79b998d112e09fc22678cd4bd838a465ee569", "commit_rev":
"527bea550106b69c89b1ddbd026498e5396c6ec0"}

[commit-bot: I haz the power, 2017-05-15 19:15:40]

Description was changed from

==========
chromeos: Adds --mus flag

This changes the mus flag to a multi-value setting the changes between no switch
(the default) --mus and --mash

BUG=none
TEST=none
R=jamescook@chromium.org
==========

to

==========
chromeos: Adds --mus flag

This changes the mus flag to a multi-value setting the changes between no switch
(the default) --mus and --mash

BUG=none
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2870893003
Cr-Commit-Position: refs/heads/master@{#471859}
Committed:
https://chromium.googlesource.com/chromium/src/+/527bea550106b69c89b1ddbd0264...
==========

[commit-bot: I haz the power, 2017-05-15 19:15:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/527bea550106b69c89b1ddbd0264...