Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2870893003: chromeos: Adds --mus flag (Closed)
Patch Set: feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 {flags_ui::kGenericExperimentChoiceDefault, "", ""}, 449 {flags_ui::kGenericExperimentChoiceDefault, "", ""},
450 {flags_ui::kGenericExperimentChoiceEnabled, 450 {flags_ui::kGenericExperimentChoiceEnabled,
451 chromeos::switches::kEnableDataSaverPrompt, ""}, 451 chromeos::switches::kEnableDataSaverPrompt, ""},
452 {flags_ui::kGenericExperimentChoiceDisabled, 452 {flags_ui::kGenericExperimentChoiceDisabled,
453 chromeos::switches::kDisableDataSaverPrompt, ""}, 453 chromeos::switches::kDisableDataSaverPrompt, ""},
454 {flag_descriptions::kDatasaverPromptDemoMode, 454 {flag_descriptions::kDatasaverPromptDemoMode,
455 chromeos::switches::kEnableDataSaverPrompt, 455 chromeos::switches::kEnableDataSaverPrompt,
456 chromeos::switches::kDataSaverPromptDemoMode}, 456 chromeos::switches::kDataSaverPromptDemoMode},
457 }; 457 };
458 458
459 const FeatureEntry::Choice kUseMusChoices[] = {
460 {flags_ui::kGenericExperimentChoiceDefault, "", ""},
461 {flag_descriptions::kEnableMusDescription, switches::kMus, ""},
462 {flag_descriptions::kEnableMashDescription, switches::kMash, ""},
463 };
464
459 const FeatureEntry::Choice kUiShowCompositedLayerBordersChoices[] = { 465 const FeatureEntry::Choice kUiShowCompositedLayerBordersChoices[] = {
460 {flags_ui::kGenericExperimentChoiceDefault, "", ""}, 466 {flags_ui::kGenericExperimentChoiceDefault, "", ""},
461 {flag_descriptions::kUiShowCompositedLayerBordersRenderPass, 467 {flag_descriptions::kUiShowCompositedLayerBordersRenderPass,
462 cc::switches::kUIShowCompositedLayerBorders, 468 cc::switches::kUIShowCompositedLayerBorders,
463 cc::switches::kCompositedRenderPassBorders}, 469 cc::switches::kCompositedRenderPassBorders},
464 {flag_descriptions::kUiShowCompositedLayerBordersSurface, 470 {flag_descriptions::kUiShowCompositedLayerBordersSurface,
465 cc::switches::kUIShowCompositedLayerBorders, 471 cc::switches::kUIShowCompositedLayerBorders,
466 cc::switches::kCompositedSurfaceBorders}, 472 cc::switches::kCompositedSurfaceBorders},
467 {flag_descriptions::kUiShowCompositedLayerBordersLayer, 473 {flag_descriptions::kUiShowCompositedLayerBordersLayer,
468 cc::switches::kUIShowCompositedLayerBorders, 474 cc::switches::kUIShowCompositedLayerBorders,
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
1269 FEATURE_VALUE_TYPE(features::kPreferHtmlOverPlugins)}, 1275 FEATURE_VALUE_TYPE(features::kPreferHtmlOverPlugins)},
1270 {"allow-nacl-socket-api", flag_descriptions::kAllowNaclSocketApiName, 1276 {"allow-nacl-socket-api", flag_descriptions::kAllowNaclSocketApiName,
1271 flag_descriptions::kAllowNaclSocketApiDescription, kOsDesktop, 1277 flag_descriptions::kAllowNaclSocketApiDescription, kOsDesktop,
1272 SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")}, 1278 SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")},
1273 {"run-all-flash-in-allow-mode", 1279 {"run-all-flash-in-allow-mode",
1274 flag_descriptions::kRunAllFlashInAllowModeName, 1280 flag_descriptions::kRunAllFlashInAllowModeName,
1275 flag_descriptions::kRunAllFlashInAllowModeDescription, kOsDesktop, 1281 flag_descriptions::kRunAllFlashInAllowModeDescription, kOsDesktop,
1276 FEATURE_VALUE_TYPE(features::kRunAllFlashInAllowMode)}, 1282 FEATURE_VALUE_TYPE(features::kRunAllFlashInAllowMode)},
1277 #endif // ENABLE_PLUGINS 1283 #endif // ENABLE_PLUGINS
1278 #if defined(OS_CHROMEOS) 1284 #if defined(OS_CHROMEOS)
1279 {"mash", flag_descriptions::kUseMashName, 1285 {"mus", flag_descriptions::kUseMusName,
1280 flag_descriptions::kUseMashDescription, kOsCrOS, 1286 flag_descriptions::kUseMusDescription, kOsCrOS,
1281 SINGLE_VALUE_TYPE(switches::kMash)}, 1287 MULTI_VALUE_TYPE(kUseMusChoices)},
1282 {"allow-touchpad-three-finger-click", 1288 {"allow-touchpad-three-finger-click",
1283 flag_descriptions::kAllowTouchpadThreeFingerClickName, 1289 flag_descriptions::kAllowTouchpadThreeFingerClickName,
1284 flag_descriptions::kAllowTouchpadThreeFingerClickDescription, kOsCrOS, 1290 flag_descriptions::kAllowTouchpadThreeFingerClickDescription, kOsCrOS,
1285 SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchpadThreeFingerClick)}, 1291 SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchpadThreeFingerClick)},
1286 {"ash-enable-unified-desktop", 1292 {"ash-enable-unified-desktop",
1287 flag_descriptions::kAshEnableUnifiedDesktopName, 1293 flag_descriptions::kAshEnableUnifiedDesktopName,
1288 flag_descriptions::kAshEnableUnifiedDesktopDescription, kOsCrOS, 1294 flag_descriptions::kAshEnableUnifiedDesktopDescription, kOsCrOS,
1289 SINGLE_VALUE_TYPE(switches::kEnableUnifiedDesktop)}, 1295 SINGLE_VALUE_TYPE(switches::kEnableUnifiedDesktop)},
1290 {"enable-easy-unlock-proximity-detection", 1296 {"enable-easy-unlock-proximity-detection",
1291 flag_descriptions::kEasyUnlockProximityDetectionName, 1297 flag_descriptions::kEasyUnlockProximityDetectionName,
(...skipping 1660 matching lines...) Expand 10 before | Expand all | Expand 10 after
2952 if (!strcmp("enable-data-reduction-proxy-carrier-test", 2958 if (!strcmp("enable-data-reduction-proxy-carrier-test",
2953 entry.internal_name) && 2959 entry.internal_name) &&
2954 channel != version_info::Channel::DEV && 2960 channel != version_info::Channel::DEV &&
2955 channel != version_info::Channel::CANARY && 2961 channel != version_info::Channel::CANARY &&
2956 channel != version_info::Channel::UNKNOWN) { 2962 channel != version_info::Channel::UNKNOWN) {
2957 return true; 2963 return true;
2958 } 2964 }
2959 #endif // OS_ANDROID 2965 #endif // OS_ANDROID
2960 2966
2961 #if defined(OS_CHROMEOS) 2967 #if defined(OS_CHROMEOS)
2962 // Don't expose --mash outside of Canary or developer builds. 2968 // Don't expose --mash/--mus outside of Canary or developer builds.
2963 if (!strcmp("mash", entry.internal_name) && 2969 if (!strcmp("mus", entry.internal_name) &&
2964 channel != version_info::Channel::DEV && 2970 channel != version_info::Channel::DEV &&
2965 channel != version_info::Channel::UNKNOWN) { 2971 channel != version_info::Channel::UNKNOWN) {
2966 return true; 2972 return true;
2967 } 2973 }
2968 #endif // defined(OS_CHROMEOS) 2974 #endif // defined(OS_CHROMEOS)
2969 2975
2970 // data-reduction-proxy-lo-fi and enable-data-reduction-proxy-lite-page 2976 // data-reduction-proxy-lo-fi and enable-data-reduction-proxy-lite-page
2971 // are only available for Chromium builds and the Canary/Dev/Beta channels. 2977 // are only available for Chromium builds and the Canary/Dev/Beta channels.
2972 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) || 2978 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) ||
2973 !strcmp("enable-data-reduction-proxy-lite-page", 2979 !strcmp("enable-data-reduction-proxy-lite-page",
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
3126 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3132 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3127 3133
3128 const FeatureEntry* GetFeatureEntries(size_t* count) { 3134 const FeatureEntry* GetFeatureEntries(size_t* count) {
3129 *count = arraysize(kFeatureEntries); 3135 *count = arraysize(kFeatureEntries);
3130 return kFeatureEntries; 3136 return kFeatureEntries;
3131 } 3137 }
3132 3138
3133 } // namespace testing 3139 } // namespace testing
3134 3140
3135 } // namespace about_flags 3141 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698