SW Image Decode Cache Low to Medium Quality for Downscale

SW Image Decode Cache Low to Medium Quality for Downscale

When using the SW Image Decode Cache, low quality images are kept at
full resolution, and scaled at raster time using a low-quality filter.

While this is cheap from a performance standpoint (no decode-time
scale), it increases the cost of storing these images, as they are
always stored at full resolution.

This change causes us to use medium quality scaling for images which
request a low quality downscale. This will generate a mip-level scale,
and cache that, potentially reducing our cache size.

While this could have a performance cost, this is already the path
used by the GPU cache, and we haven't observed performance problems
there.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2870753002
Cr-Commit-Position: refs/heads/master@{#473090}
Committed: https://chromium.googlesource.com/chromium/src/+/9d1c3d7252f0371e7df6e2519eed6462e9e00a12

[ericrk, 2017-05-08 21:57:30]

Description was changed from

==========
SW Image Decode Cache Low to Medium Quality for Downscale

When using the SW Image Decode Cache, low quality images are kept at
full resolution, and scaled at raster time using a low-quality filter.

While this is cheap from a performance standpoint (no decode-time
scale), it increases the cost of storing these images, as they are
always stored at full resolution.

This change causes us to use medium quality scaling for images which
request a low quality downscale. This will generate a mip-level scale,
and cache that, potentially reducing our cache size.

While this could have a performance cost, this is already the path
used by the GPU cache, and we haven't observed performance problems
there.
==========

to

==========
SW Image Decode Cache Low to Medium Quality for Downscale

When using the SW Image Decode Cache, low quality images are kept at
full resolution, and scaled at raster time using a low-quality filter.

While this is cheap from a performance standpoint (no decode-time
scale), it increases the cost of storing these images, as they are
always stored at full resolution.

This change causes us to use medium quality scaling for images which
request a low quality downscale. This will generate a mip-level scale,
and cache that, potentially reducing our cache size.

While this could have a performance cost, this is already the path
used by the GPU cache, and we haven't observed performance problems
there.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ericrk, 2017-05-08 22:02:13]

ericrk@chromium.org changed reviewers:
+ vmpstr@chromium.org

[ericrk, 2017-05-08 22:02:18]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 22:04:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:49:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-05-08 22:52:04]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-08 22:52:05]

The CQ bit was unchecked by ericrk@chromium.org

[ericrk, 2017-05-08 22:52:08]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[ericrk, 2017-05-08 22:52:12]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 22:57:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:21:19]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[vmpstr, 2017-05-09 21:58:14]

lgtm, you'll have to rebaseline the bots but from the looks of the linux one the
results are better than before (as expected). Thanks!

[ericrk, 2017-05-10 18:47:01]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-10 18:47:01]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2870753002/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-05-10 18:48:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:54:47]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ericrk, 2017-05-10 20:55:34]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:56:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 03:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 03:04:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-05-11 16:53:49]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:54:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:05:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-05-11 20:17:09]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-11 20:17:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:24:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-05-17 20:32:03]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:34:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:41:08]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2017-05-17 21:20:35]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:21:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:28:01]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2017-05-18 00:43:50]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-18 00:43:51]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2870753002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-18 00:45:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 00:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:51:50]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2017-05-18 01:00:32]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-18 01:00:32]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2870753002/#ps80001
(title: "rebase fixes")

[commit-bot: I haz the power, 2017-05-18 01:01:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:23:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2017-05-18 16:00:51]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-18 16:01:14]

The CQ bit was unchecked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-18 16:01:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ericrk, 2017-05-18 18:23:40]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-18 18:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2870753002/#ps120001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-05-18 18:24:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:08:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ericrk, 2017-05-19 00:12:32]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:13:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 04:58:52]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495152752604610,
"parent_rev": "cd916cc43984ff94e84fd5716c8e5d6d04416ec6", "commit_rev":
"9d1c3d7252f0371e7df6e2519eed6462e9e00a12"}

[commit-bot: I haz the power, 2017-05-19 04:59:04]

Description was changed from

==========
SW Image Decode Cache Low to Medium Quality for Downscale

When using the SW Image Decode Cache, low quality images are kept at
full resolution, and scaled at raster time using a low-quality filter.

While this is cheap from a performance standpoint (no decode-time
scale), it increases the cost of storing these images, as they are
always stored at full resolution.

This change causes us to use medium quality scaling for images which
request a low quality downscale. This will generate a mip-level scale,
and cache that, potentially reducing our cache size.

While this could have a performance cost, this is already the path
used by the GPU cache, and we haven't observed performance problems
there.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
SW Image Decode Cache Low to Medium Quality for Downscale

When using the SW Image Decode Cache, low quality images are kept at
full resolution, and scaled at raster time using a low-quality filter.

While this is cheap from a performance standpoint (no decode-time
scale), it increases the cost of storing these images, as they are
always stored at full resolution.

This change causes us to use medium quality scaling for images which
request a low quality downscale. This will generate a mip-level scale,
and cache that, potentially reducing our cache size.

While this could have a performance cost, this is already the path
used by the GPU cache, and we haven't observed performance problems
there.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2870753002
Cr-Commit-Position: refs/heads/master@{#473090}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d1c3d7252f0371e7df6e2519eed...
==========

[commit-bot: I haz the power, 2017-05-19 04:59:05]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/9d1c3d7252f0371e7df6e2519eed...