Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2870703003: Revert of PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector (Closed)

Created:
3 years, 7 months ago by JaideepBajwa
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector (patchset #1 id:1 of https://codereview.chromium.org/2861863003/ ) Reason for revert: Original CL reverted. Crashing on Canary BUG=chromium:718891 Original issue's description: > PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector > > Port 662aa425bac00f468d2b2e91a149b5f35e2a4ad3 > > Original Commit Message: > > Since the feedback vector is itself a native context structure, why > not store optimized code for a function in there rather than in > a map from native context to code? This allows us to get rid of > the optimized code map in the SharedFunctionInfo, saving a pointer, > and making lookup of any optimized code quicker. > > Original patch by Michael Stanton <mvstanton@chromium.org>; > > R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG=v8:6246 > LOG=N > > Review-Url: https://codereview.chromium.org/2861863003 > Cr-Commit-Position: refs/heads/master@{#45111} > Committed: https://chromium.googlesource.com/v8/v8/+/d587812258c232f7b9a1f1a9a017ba3f9cea12ea TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,rmcilroy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:6246 Review-Url: https://codereview.chromium.org/2870703003 Cr-Commit-Position: refs/heads/master@{#45195} Committed: https://chromium.googlesource.com/v8/v8/+/c33b25bf6357ab30af57bbb1693ed383a2756f44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -25 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +50 lines, -11 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +54 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
JaideepBajwa
Created Revert of PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector
3 years, 7 months ago (2017-05-09 03:20:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870703003/1
3 years, 7 months ago (2017-05-09 03:21:00 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-09 03:21:02 UTC) #5
JaideepBajwa
ptal
3 years, 7 months ago (2017-05-09 03:21:15 UTC) #6
john.yan
lgtm
3 years, 7 months ago (2017-05-09 05:14:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870703003/1
3 years, 7 months ago (2017-05-09 13:06:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 13:46:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c33b25bf6357ab30af57bbb1693ed383a27...

Powered by Google App Engine
This is Rietveld 408576698