Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 2861863003: PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector (Closed)

Created:
3 years, 7 months ago by JaideepBajwa
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Reland: [TypeFeedbackVector] Store optimized code in the vector Port 662aa425bac00f468d2b2e91a149b5f35e2a4ad3 Original Commit Message: Since the feedback vector is itself a native context structure, why not store optimized code for a function in there rather than in a map from native context to code? This allows us to get rid of the optimized code map in the SharedFunctionInfo, saving a pointer, and making lookup of any optimized code quicker. Original patch by Michael Stanton <mvstanton@chromium.org>; R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6246 LOG=N Review-Url: https://codereview.chromium.org/2861863003 Cr-Commit-Position: refs/heads/master@{#45111} Committed: https://chromium.googlesource.com/v8/v8/+/d587812258c232f7b9a1f1a9a017ba3f9cea12ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -104 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +11 lines, -50 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +14 lines, -54 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 7 months ago (2017-05-04 15:54:05 UTC) #1
john.yan
lgtm
3 years, 7 months ago (2017-05-04 16:40:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861863003/1
3 years, 7 months ago (2017-05-04 18:30:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/d587812258c232f7b9a1f1a9a017ba3f9cea12ea
3 years, 7 months ago (2017-05-04 19:02:34 UTC) #7
JaideepBajwa
3 years, 7 months ago (2017-05-09 03:20:57 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2870703003/ by bjaideep@ca.ibm.com.

The reason for reverting is: Original CL reverted.
Crashing on Canary
BUG=chromium:718891.

Powered by Google App Engine
This is Rietveld 408576698