Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870563003:
Only build non rlz_utils targets in non android platforms (Closed)
|
Created:
3 years, 7 months ago by Yusuf Modified:
3 years, 7 months ago Reviewers:
Roger Tawa OOO till Jul 10th CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOnly build non rlz_utils targets in non android platforms
Right now rlz_utils contains basic dependencies that defines constants
etc, but when that is included, the target "all" ends up building all
targets in this file (because including rlz_utils makes the bots use
this file for the first time) and that break android builds. Move all
other targets to a !is_android condition
BUG=713956
Review-Url: https://codereview.chromium.org/2870563003
Cr-Commit-Position: refs/heads/master@{#470247}
Committed: https://chromium.googlesource.com/chromium/src/+/0979251b5a413aa37bb82e8d72d75cd7a1c5e106
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
yusufo@chromium.org changed reviewers: + rogerta@chromium.org
The CQ bit was checked by yusufo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by yusufo@chromium.org
The CQ bit was checked by yusufo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yusufo@chromium.org
The CQ bit was checked by yusufo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yusufo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yusufo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494307176342690, "parent_rev":
"0af11b911decff157cc123f4e59c16c8295e2200", "commit_rev":
"0979251b5a413aa37bb82e8d72d75cd7a1c5e106"}
Message was sent while issue was closed.
Description was changed from ========== Only build non rlz_utils targets in non android platforms Right now rlz_utils contains basic dependencies that defines constants etc, but when that is included, the target "all" ends up building all targets in this file (because including rlz_utils makes the bots use this file for the first time) and that break android builds. Move all other targets to a !is_android condition BUG=713956 ========== to ========== Only build non rlz_utils targets in non android platforms Right now rlz_utils contains basic dependencies that defines constants etc, but when that is included, the target "all" ends up building all targets in this file (because including rlz_utils makes the bots use this file for the first time) and that break android builds. Move all other targets to a !is_android condition BUG=713956 Review-Url: https://codereview.chromium.org/2870563003 Cr-Commit-Position: refs/heads/master@{#470247} Committed: https://chromium.googlesource.com/chromium/src/+/0979251b5a413aa37bb82e8d72d7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0979251b5a413aa37bb82e8d72d7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
