Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: rlz/BUILD.gn

Issue 2870563003: Only build non rlz_utils targets in non android platforms (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/BUILD.gn
diff --git a/rlz/BUILD.gn b/rlz/BUILD.gn
index f830d26a1ba2d6ee7b4c209e3978017a1a666198..229991f72397dbb406e44189d9648292f1021fdd 100644
--- a/rlz/BUILD.gn
+++ b/rlz/BUILD.gn
@@ -11,72 +11,6 @@ config("rlz_config") {
defines = [ "RLZ_NETWORK_IMPLEMENTATION_CHROME_NET" ]
}
-source_set("rlz_lib") {
- sources = [
- "chromeos/lib/machine_id_chromeos.cc",
- "chromeos/lib/rlz_value_store_chromeos.cc",
- "chromeos/lib/rlz_value_store_chromeos.h",
- "ios/lib/machine_id_ios.cc",
- "lib/crc8.cc",
- "lib/crc8.h",
- "lib/financial_ping.cc",
- "lib/financial_ping.h",
- "lib/machine_id.cc",
- "lib/machine_id.h",
- "lib/recursive_cross_process_lock_posix.cc",
- "lib/recursive_cross_process_lock_posix.h",
- "lib/rlz_lib.cc",
- "lib/rlz_lib.h",
- "lib/rlz_lib_clear.cc",
- "lib/rlz_value_store.h",
- "mac/lib/machine_id_mac.cc",
- "mac/lib/rlz_value_store_mac.h",
- "mac/lib/rlz_value_store_mac.mm",
- "win/lib/lib_mutex.cc",
- "win/lib/lib_mutex.h",
- "win/lib/machine_deal.cc",
- "win/lib/machine_deal.h",
- "win/lib/machine_id_win.cc",
- "win/lib/process_info.cc",
- "win/lib/process_info.h",
- "win/lib/registry_util.cc",
- "win/lib/registry_util.h",
- "win/lib/rlz_lib_win.cc",
- "win/lib/rlz_value_store_registry.cc",
- "win/lib/rlz_value_store_registry.h",
- ]
-
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
- public_configs = [ ":rlz_config" ]
-
- deps = [
- ":rlz_utils",
- "//base",
- "//base/third_party/dynamic_annotations",
- "//net",
- "//url",
- ]
-
- if (is_mac) {
- libs = [
- "Foundation.framework",
- "IOKit.framework",
- ]
- }
-
- if (is_ios) {
- # These _mac files are also used on iOS.
- set_sources_assignment_filter([])
- sources += [
- "mac/lib/rlz_value_store_mac.h",
- "mac/lib/rlz_value_store_mac.mm",
- ]
- set_sources_assignment_filter(sources_assignment_filter)
- }
-}
-
source_set("rlz_utils") {
sources = [
"lib/assert.cc",
@@ -103,49 +37,117 @@ source_set("rlz_utils") {
]
}
-source_set("test_support") {
- testonly = true
- sources = [
- "test/rlz_test_helpers.cc",
- "test/rlz_test_helpers.h",
- ]
- deps = [
- ":rlz_lib",
- "//base",
- "//base/test:test_support",
- "//testing/gtest",
- ]
-}
+if (!is_android) {
+ source_set("rlz_lib") {
+ sources = [
+ "chromeos/lib/machine_id_chromeos.cc",
+ "chromeos/lib/rlz_value_store_chromeos.cc",
+ "chromeos/lib/rlz_value_store_chromeos.h",
+ "ios/lib/machine_id_ios.cc",
+ "lib/crc8.cc",
+ "lib/crc8.h",
+ "lib/financial_ping.cc",
+ "lib/financial_ping.h",
+ "lib/machine_id.cc",
+ "lib/machine_id.h",
+ "lib/recursive_cross_process_lock_posix.cc",
+ "lib/recursive_cross_process_lock_posix.h",
+ "lib/rlz_lib.cc",
+ "lib/rlz_lib.h",
+ "lib/rlz_lib_clear.cc",
+ "lib/rlz_value_store.h",
+ "mac/lib/machine_id_mac.cc",
+ "mac/lib/rlz_value_store_mac.h",
+ "mac/lib/rlz_value_store_mac.mm",
+ "win/lib/lib_mutex.cc",
+ "win/lib/lib_mutex.h",
+ "win/lib/machine_deal.cc",
+ "win/lib/machine_deal.h",
+ "win/lib/machine_id_win.cc",
+ "win/lib/process_info.cc",
+ "win/lib/process_info.h",
+ "win/lib/registry_util.cc",
+ "win/lib/registry_util.h",
+ "win/lib/rlz_lib_win.cc",
+ "win/lib/rlz_value_store_registry.cc",
+ "win/lib/rlz_value_store_registry.h",
+ ]
-test("rlz_unittests") {
- sources = [
- "lib/crc32_unittest.cc",
- "lib/crc8_unittest.cc",
- "lib/financial_ping_test.cc",
- "lib/lib_values_unittest.cc",
- "lib/machine_id_unittest.cc",
- "lib/rlz_lib_test.cc",
- "lib/string_utils_unittest.cc",
- "test/rlz_unittest_main.cc",
- "win/lib/machine_deal_test.cc",
- ]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+ public_configs = [ ":rlz_config" ]
- deps = [
- ":rlz_lib",
- ":rlz_utils",
- ":test_support",
- "//base",
- "//net:test_support",
- "//testing/gmock",
- "//testing/gtest",
- "//third_party/zlib",
- ]
+ deps = [
+ ":rlz_utils",
+ "//base",
+ "//base/third_party/dynamic_annotations",
+ "//net",
+ "//url",
+ ]
+
+ if (is_mac) {
+ libs = [
+ "Foundation.framework",
+ "IOKit.framework",
+ ]
+ }
+
+ if (is_ios) {
+ # These _mac files are also used on iOS.
+ set_sources_assignment_filter([])
+ sources += [
+ "mac/lib/rlz_value_store_mac.h",
+ "mac/lib/rlz_value_store_mac.mm",
+ ]
+ set_sources_assignment_filter(sources_assignment_filter)
+ }
+ }
+
+ source_set("test_support") {
+ testonly = true
+ sources = [
+ "test/rlz_test_helpers.cc",
+ "test/rlz_test_helpers.h",
+ ]
+ deps = [
+ ":rlz_lib",
+ "//base",
+ "//base/test:test_support",
+ "//testing/gtest",
+ ]
+ }
+
+ test("rlz_unittests") {
+ sources = [
+ "lib/crc32_unittest.cc",
+ "lib/crc8_unittest.cc",
+ "lib/financial_ping_test.cc",
+ "lib/lib_values_unittest.cc",
+ "lib/machine_id_unittest.cc",
+ "lib/rlz_lib_test.cc",
+ "lib/string_utils_unittest.cc",
+ "test/rlz_unittest_main.cc",
+ "win/lib/machine_deal_test.cc",
+ ]
+
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
+ deps = [
+ ":rlz_lib",
+ ":rlz_utils",
+ ":test_support",
+ "//base",
+ "//net:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/zlib",
+ ]
+ }
}
-if (!is_ios) {
+if (!is_ios && !is_android) {
executable("rlz_id") {
sources = [
"examples/rlz_id.cc",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698