Issue 2870553003: WebVR: Don't crash when receiving null image from rendering context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2870553003: WebVR: Don't crash when receiving null image from rendering context. (Closed)

Created:
3 years, 7 months ago by mthiesse

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

WebVR: Don't crash when receiving null image from rendering context. Not sure why/how this happens, but I was seeing this infrequently on https://with.in/watch/under-neon-lights/ BUG=718501 Review-Url: https://codereview.chromium.org/2862883002 Cr-Commit-Position: refs/heads/master@{#469517} (cherry picked from commit a1215009f69ac267d13b072cc2d4c9cda7155fee) Review-Url: https://codereview.chromium.org/2870553003 . Cr-Commit-Position: refs/branch-heads/3071@{#446} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2ce7c2c63299607f9f56302e7a12c4be34a0fa32

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/Source/modules/vr/VRDisplay.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

mthiesse

3 years, 7 months ago (2017-05-08 15:08:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ce7c2c63299607f9f56302e7a12c4be34a0fa32.