Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2862883002: WebVR: Don't crash when receiving null image from rendering context. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
klausw, bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: Don't crash when receiving null image from rendering context. Not sure why/how this happens, but I was seeing this infrequently on https://with.in/watch/under-neon-lights/ BUG=718501 Review-Url: https://codereview.chromium.org/2862883002 Cr-Commit-Position: refs/heads/master@{#469517} Committed: https://chromium.googlesource.com/chromium/src/+/a1215009f69ac267d13b072cc2d4c9cda7155fee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mthiesse
PTAL
3 years, 7 months ago (2017-05-04 18:00:19 UTC) #3
bajones
lgtm
3 years, 7 months ago (2017-05-04 21:17:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862883002/1
3 years, 7 months ago (2017-05-04 21:18:49 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:29:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1215009f69ac267d13b072cc2d4...

Powered by Google App Engine
This is Rietveld 408576698