Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/mb/mb_config.pyl

Issue 2870543003: win: Set is_clang=true by default. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index 57e79d710b8059158bd58bdc7d2162a3f01a46df..07e26d69bbc662763ab018db13f4e59f9b1bb667 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -1500,7 +1500,10 @@
],
'win_clang_debug_bot': [
- 'clang', 'debug_bot', 'minimal_symbols',
+ # TODO(thakis): Now that the default win bots uss clang, use win_clang
hans 2017/05/15 17:22:43 s/uss/use/
+ # to make sure things stay compilable with msvc. Having "win_clang"
+ # check that is very confusing, so rename the bot to win_msvc.
+ 'no_clang', 'debug_bot', 'minimal_symbols',
],
'windows_analyze': [
@@ -1590,11 +1593,11 @@
},
'chrome_pgo_phase_1': {
- 'gn_args': 'chrome_pgo_phase=1',
+ 'gn_args': 'chrome_pgo_phase=1 is_clang=false',
},
'chrome_pgo_phase_2': {
- 'gn_args': 'chrome_pgo_phase=2',
+ 'gn_args': 'chrome_pgo_phase=2 is_clang=false',
},
'chrome_with_codecs': {
@@ -1622,6 +1625,10 @@
'gn_args': 'is_clang=true',
},
+ 'no_clang': {
+ 'gn_args': 'is_clang=true',
Nico 2017/05/17 22:27:48 whooooooooops
hans 2017/05/17 22:36:45 But it said no_clang on the tin!
+ },
+
'cronet': {
'gn_args': ('disable_file_support=true disable_ftp_support=true '
'enable_websockets=false use_platform_icu_alternatives=true '
@@ -1869,7 +1876,8 @@
},
'syzyasan': {
- 'gn_args': 'is_syzyasan=true',
+ # TODO(thakis): Figure out SyzyASan + clang story.
+ 'gn_args': 'is_syzyasan=true is_clang=false',
},
'thin_lto': {
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698