Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2870523002: Revert of Changing default Windows compiler to VS 2017 (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 3 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2863313002/ ) Reason for revert: We hopefully had a canary with this by now. Original issue's description: > Reland of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2851143002/ ) > > Reason for revert: > Trying to get another canary built over the weekend. Will revert again on Sunday. > > Original issue's description: > > Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2852433005/ ) > > > > Reason for revert: > > Reverting as planned - it was just a test switch to VS 2017, which seems to have gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017, to > > complete the test. > > > > Original issue's description: > > > Changing default Windows compiler to VS 2017 > > > > > > This is a single character change to temporarily switch Chrome to > > > building with VC++ 2017. This CL is currently purely for testing > > > purposes and will be landed for the weekend in order to flesh out any > > > remaining bugs. > > > > > > This is a retry of crrev.com/2762093003 which failed due to a compiler > > > warning which was missed in local testing and the try bots. That warning > > > has been resolved and a local build of 'all' completed cleanly. > > > > > > BUG=683729 > > > > > > Review-Url: https://codereview.chromium.org/2852433005 > > > Cr-Commit-Position: refs/heads/master@{#468239} > > > Committed: https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564792272ed34a3 > > > > TBR=thakis@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=683729 > > > > Review-Url: https://codereview.chromium.org/2851143002 > > Cr-Commit-Position: refs/heads/master@{#468298} > > Committed: https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c7181a409b45b > > TBR=brucedawson@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=683729 > > Review-Url: https://codereview.chromium.org/2863313002 > Cr-Commit-Position: refs/heads/master@{#469843} > Committed: https://chromium.googlesource.com/chromium/src/+/ce36c5acc6e27a75e8fa455c92277de713922ac0 TBR=brucedawson@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=683729 NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
Nico
Created Revert of Changing default Windows compiler to VS 2017
3 years, 7 months ago (2017-05-07 23:56:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870523002/1
3 years, 7 months ago (2017-05-07 23:56:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/420275)
3 years, 7 months ago (2017-05-08 01:16:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870523002/1
3 years, 7 months ago (2017-05-08 01:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870523002/1
3 years, 7 months ago (2017-05-08 01:24:52 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
3 years, 7 months ago (2017-05-08 01:31:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870523002/1
3 years, 7 months ago (2017-05-08 02:03:32 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 02:11:13 UTC) #20
Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698