Revert of Changing default Windows compiler to VS 2017

Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2852433005/ )

Reason for revert:
Reverting as planned - it was just a test switch to VS 2017, which seems to have gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017, to
complete the test.

Original issue's description:
> Changing default Windows compiler to VS 2017
> 
> This is a single character change to temporarily switch Chrome to
> building with VC++ 2017. This CL is currently purely for testing
> purposes and will be landed for the weekend in order to flesh out any
> remaining bugs.
> 
> This is a retry of crrev.com/2762093003 which failed due to a compiler
> warning which was missed in local testing and the try bots. That warning
> has been resolved and a local build of 'all' completed cleanly.
> 
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2852433005
> Cr-Commit-Position: refs/heads/master@{#468239}
> Committed: https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564792272ed34a3

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729
Review-Url: https://codereview.chromium.org/2851143002
Cr-Commit-Position: refs/heads/master@{#468298}
Committed: https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c7181a409b45b

[brucedawson, 2017-05-01 02:56:40]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2017-05-01 02:56:40]

Created Revert of Changing default Windows compiler to VS 2017

[commit-bot: I haz the power, 2017-05-01 02:56:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-05-01 03:24:37]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2017-05-01 04:37:55]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 04:38:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 04:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 04:41:57]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-05-01 06:45:13]

Description was changed from

==========
Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2852433005/ )

Reason for revert:
Reverting as planned - it was just a test switch to VS 2017, which seems to have
gone smoothly, although crash results still need examination.

Canary 60.0.3085.0 was built with VS 2017.

Original issue's description:
> Changing default Windows compiler to VS 2017
> 
> This is a single character change to temporarily switch Chrome to
> building with VC++ 2017. This CL is currently purely for testing
> purposes and will be landed for the weekend in order to flesh out any
> remaining bugs.
> 
> This is a retry of crrev.com/2762093003 which failed due to a compiler
> warning which was missed in local testing and the try bots. That warning
> has been resolved and a local build of 'all' completed cleanly.
> 
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2852433005
> Cr-Commit-Position: refs/heads/master@{#468239}
> Committed:
https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729
==========

to

==========
Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2852433005/ )

Reason for revert:
Reverting as planned - it was just a test switch to VS 2017, which seems to have
gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017,
to
complete the test.

Original issue's description:
> Changing default Windows compiler to VS 2017
> 
> This is a single character change to temporarily switch Chrome to
> building with VC++ 2017. This CL is currently purely for testing
> purposes and will be landed for the weekend in order to flesh out any
> remaining bugs.
> 
> This is a retry of crrev.com/2762093003 which failed due to a compiler
> warning which was missed in local testing and the try bots. That warning
> has been resolved and a local build of 'all' completed cleanly.
> 
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2852433005
> Cr-Commit-Position: refs/heads/master@{#468239}
> Committed:
https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729
==========

[brucedawson, 2017-05-01 06:45:24]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-05-01 06:45:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 06:49:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493621124987380, "parent_rev":
"67ed5fd8781049a3566ce37426bceae03bca942d", "commit_rev":
"93cf7d6a5e0ccbb248ac818c3c7c7181a409b45b"}

[commit-bot: I haz the power, 2017-05-01 06:50:09]

Description was changed from

==========
Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2852433005/ )

Reason for revert:
Reverting as planned - it was just a test switch to VS 2017, which seems to have
gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017,
to
complete the test.

Original issue's description:
> Changing default Windows compiler to VS 2017
> 
> This is a single character change to temporarily switch Chrome to
> building with VC++ 2017. This CL is currently purely for testing
> purposes and will be landed for the weekend in order to flesh out any
> remaining bugs.
> 
> This is a retry of crrev.com/2762093003 which failed due to a compiler
> warning which was missed in local testing and the try bots. That warning
> has been resolved and a local build of 'all' completed cleanly.
> 
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2852433005
> Cr-Commit-Position: refs/heads/master@{#468239}
> Committed:
https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729
==========

to

==========
Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2852433005/ )

Reason for revert:
Reverting as planned - it was just a test switch to VS 2017, which seems to have
gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017,
to
complete the test.

Original issue's description:
> Changing default Windows compiler to VS 2017
> 
> This is a single character change to temporarily switch Chrome to
> building with VC++ 2017. This CL is currently purely for testing
> purposes and will be landed for the weekend in order to flesh out any
> remaining bugs.
> 
> This is a retry of crrev.com/2762093003 which failed due to a compiler
> warning which was missed in local testing and the try bots. That warning
> has been resolved and a local build of 'all' completed cleanly.
> 
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2852433005
> Cr-Commit-Position: refs/heads/master@{#468239}
> Committed:
https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729

Review-Url: https://codereview.chromium.org/2851143002
Cr-Commit-Position: refs/heads/master@{#468298}
Committed:
https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c...
==========

[commit-bot: I haz the power, 2017-05-01 06:50:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c...

[Nico, 2017-05-06 14:31:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2863313002/ by thakis@chromium.org.

The reason for reverting is: Trying to get another canary built over the
weekend. Will revert again on Sunday..