Reland of Changing default Windows compiler to VS 2017

Reland of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2851143002/ )

Reason for revert:
Trying to get another canary built over the weekend. Will revert again on Sunday.

Original issue's description:
> Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of https://codereview.chromium.org/2852433005/ )
> 
> Reason for revert:
> Reverting as planned - it was just a test switch to VS 2017, which seems to have gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS 2017, to
> complete the test.
> 
> Original issue's description:
> > Changing default Windows compiler to VS 2017
> > 
> > This is a single character change to temporarily switch Chrome to
> > building with VC++ 2017. This CL is currently purely for testing
> > purposes and will be landed for the weekend in order to flesh out any
> > remaining bugs.
> > 
> > This is a retry of crrev.com/2762093003 which failed due to a compiler
> > warning which was missed in local testing and the try bots. That warning
> > has been resolved and a local build of 'all' completed cleanly.
> > 
> > BUG=683729
> > 
> > Review-Url: https://codereview.chromium.org/2852433005
> > Cr-Commit-Position: refs/heads/master@{#468239}
> > Committed: https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564792272ed34a3
> 
> TBR=thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2851143002
> Cr-Commit-Position: refs/heads/master@{#468298}
> Committed: https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c7181a409b45b

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729
Review-Url: https://codereview.chromium.org/2863313002
Cr-Commit-Position: refs/heads/master@{#469843}
Committed: https://chromium.googlesource.com/chromium/src/+/ce36c5acc6e27a75e8fa455c92277de713922ac0

[Nico, 2017-05-06 14:31:42]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-05-06 14:31:43]

Created Reland of Changing default Windows compiler to VS 2017

[commit-bot: I haz the power, 2017-05-06 14:32:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 18:45:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494081102793780, "parent_rev":
"8f1d69227086e739c76da1a22a17134980cb4f6b", "commit_rev":
"ce36c5acc6e27a75e8fa455c92277de713922ac0"}

[commit-bot: I haz the power, 2017-05-06 18:46:06]

Description was changed from

==========
Reland of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2851143002/ )

Reason for revert:
Trying to get another canary built over the weekend. Will revert again on
Sunday.

Original issue's description:
> Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2852433005/ )
> 
> Reason for revert:
> Reverting as planned - it was just a test switch to VS 2017, which seems to
have gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS
2017, to
> complete the test.
> 
> Original issue's description:
> > Changing default Windows compiler to VS 2017
> > 
> > This is a single character change to temporarily switch Chrome to
> > building with VC++ 2017. This CL is currently purely for testing
> > purposes and will be landed for the weekend in order to flesh out any
> > remaining bugs.
> > 
> > This is a retry of crrev.com/2762093003 which failed due to a compiler
> > warning which was missed in local testing and the try bots. That warning
> > has been resolved and a local build of 'all' completed cleanly.
> > 
> > BUG=683729
> > 
> > Review-Url: https://codereview.chromium.org/2852433005
> > Cr-Commit-Position: refs/heads/master@{#468239}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...
> 
> TBR=thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2851143002
> Cr-Commit-Position: refs/heads/master@{#468298}
> Committed:
https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c...

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729
==========

to

==========
Reland of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2851143002/ )

Reason for revert:
Trying to get another canary built over the weekend. Will revert again on
Sunday.

Original issue's description:
> Revert of Changing default Windows compiler to VS 2017 (patchset #1 id:1 of
https://codereview.chromium.org/2852433005/ )
> 
> Reason for revert:
> Reverting as planned - it was just a test switch to VS 2017, which seems to
have gone smoothly. I'm hopeful that canary 60.0.3086.0 is being built with VS
2017, to
> complete the test.
> 
> Original issue's description:
> > Changing default Windows compiler to VS 2017
> > 
> > This is a single character change to temporarily switch Chrome to
> > building with VC++ 2017. This CL is currently purely for testing
> > purposes and will be landed for the weekend in order to flesh out any
> > remaining bugs.
> > 
> > This is a retry of crrev.com/2762093003 which failed due to a compiler
> > warning which was missed in local testing and the try bots. That warning
> > has been resolved and a local build of 'all' completed cleanly.
> > 
> > BUG=683729
> > 
> > Review-Url: https://codereview.chromium.org/2852433005
> > Cr-Commit-Position: refs/heads/master@{#468239}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...
> 
> TBR=thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=683729
> 
> Review-Url: https://codereview.chromium.org/2851143002
> Cr-Commit-Position: refs/heads/master@{#468298}
> Committed:
https://chromium.googlesource.com/chromium/src/+/93cf7d6a5e0ccbb248ac818c3c7c...

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=683729

Review-Url: https://codereview.chromium.org/2863313002
Cr-Commit-Position: refs/heads/master@{#469843}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce36c5acc6e27a75e8fa455c9227...
==========

[commit-bot: I haz the power, 2017-05-06 18:46:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce36c5acc6e27a75e8fa455c9227...

[Avi (use Gerrit), 2017-05-07 17:46:26]

On 2017/05/06 18:46:07, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/ce36c5acc6e27a75e8fa455c9227...

FYI, Win7 Tests (dbg)(1) has been burning with a failing
NetInternalsTest.netInternalsEventsViewFilter since

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

[ RUN      ] NetInternalsTest.netInternalsEventsViewFilter
[4020:2812:0506/124712.834:INFO:media_foundation_video_encode_accelerator_win.cc(329)]
Windows versions earlier than 8 are not supported.
[4748:4508:0506/124715.663:ERROR:render_process_impl.cc(170)] WebFrame LEAKED 1
TIMES
[1308:1508:0506/124715.714:ERROR:process_win.cc(140)] Unable to terminate
process: Access is denied. (0x5)
[1308:2232:0506/124718.198:INFO:CONSOLE(1221)] "Running TestCase
NetInternalsTest.netInternalsEventsViewFilter", source: test_api.js (1221)
Backtrace:
	base::WeakPtr<base::win::ObjectWatcher>::get [0x103925A3+67]
	invalid_parameter [0x74AA1F31+161]
	std::_Tree<std::_Tset_traits<v8::internal::compiler::JSInliningHeuristic::Candidate,v8::internal::compiler::JSInliningHeuristic::CandidateCompare,v8::internal::ZoneAllocator<v8::internal::compiler::JSInliningHeuristic::Candidate>,0>
>::_Insert_nohint<v8:: [0x0C85CAED+237]
	v8::internal::compiler::JSInliningHeuristic::Reduce [0x0C85F5AE+1038]
	v8::internal::compiler::GraphReducer::Reduce [0x0C7F4E35+485]
	v8::internal::compiler::GraphReducer::ReduceTop [0x0C7F5A7A+314]
	v8::internal::compiler::GraphReducer::ReduceNode [0x0C7F5263+195]

Is it this CL?

[Nico, 2017-05-07 23:55:59]

I want to revert this tonight anyways, so we'll see.

On May 7, 2017 1:46 PM, <avi@chromium.org> wrote:

> On 2017/05/06 18:46:07, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
> https://chromium.googlesource.com/chromium/src/+/
> ce36c5acc6e27a75e8fa455c92277de713922ac0
>
> FYI, Win7 Tests (dbg)(1) has been burning with a failing
> NetInternalsTest.netInternalsEventsViewFilter since
>
> https://build.chromium.org/p/chromium.win/builders/Win7%
> 20Tests%20%28dbg%29%281%29/builds/59740
>
> [ RUN ] NetInternalsTest.netInternalsEventsViewFilter
> [4020:2812:0506/124712.834:INFO:media_foundation_video_
> encode_accelerator_win.cc(329)]
> Windows versions earlier than 8 are not supported.
> [4748:4508:0506/124715.663:ERROR:render_process_impl.cc(170)] WebFrame
> LEAKED 1
> TIMES
> [1308:1508:0506/124715.714:ERROR:process_win.cc(140)] Unable to terminate
> process: Access is denied. (0x5)
> [1308:2232:0506/124718.198:INFO:CONSOLE(1221)] "Running TestCase
> NetInternalsTest.netInternalsEventsViewFilter", source: test_api.js (1221)
> Backtrace:
> base::WeakPtr<base::win::ObjectWatcher>::get [0x103925A3+67]
> invalid_parameter [0x74AA1F31+161]
> std::_Tree<std::_Tset_traits<v8::internal::compiler::JSInliningHeuristic::
> Candidate,v8::internal::compiler::JSInliningHeuristic:
> :CandidateCompare,v8::internal::ZoneAllocator<v8::internal::compiler::
> JSInliningHeuristic::Candidate>,0>
> >::_Insert_nohint<v8:: [0x0C85CAED+237]
> v8::internal::compiler::JSInliningHeuristic::Reduce [0x0C85F5AE+1038]
> v8::internal::compiler::GraphReducer::Reduce [0x0C7F4E35+485]
> v8::internal::compiler::GraphReducer::ReduceTop [0x0C7F5A7A+314]
> v8::internal::compiler::GraphReducer::ReduceNode [0x0C7F5263+195]
>
> Is it this CL?
>
> https://codereview.chromium.org/2863313002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-05-07 23:56:36]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2870523002/ by thakis@chromium.org.

The reason for reverting is: We hopefully had a canary with this by now..

[Nico, 2017-05-08 16:25:52]

The bot went green one build after the revert went in, and the changes in
the next few builds were no-ops -- so it looks like that test failure was
probably due to vc2017.

On May 7, 2017 7:56 PM, <thakis@chromium.org> wrote:

> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2870523002/ by thakis@chromium.org.
>
> The reason for reverting is: We hopefully had a canary with this by now..
>
> https://codereview.chromium.org/2863313002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brucedawson, 2017-05-09 17:41:28]

On 2017/05/08 16:25:52, Nico wrote:
> The bot went green one build after the revert went in, and the changes in
> the next few builds were no-ops -- so it looks like that test failure was
> probably due to vc2017.
> 
> On May 7, 2017 7:56 PM, <mailto:thakis@chromium.org> wrote:
> 
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2870523002/ by mailto:thakis@chromium.org.
> >
> > The reason for reverting is: We hopefully had a canary with this by now..
> >
> > https://codereview.chromium.org/2863313002/

I'll investigate the failure, and check crash results for the VS 2017 canary (or
canaries). Do you know what canary builds ended up using VC 2017? I could
download the packages but if you know off-hand that would be helpful.

[Nico, 2017-05-09 20:14:09]

I don't know, sorry. I just landed this Sat morning and reverted Sun night.

On Tue, May 9, 2017 at 1:41 PM, <brucedawson@chromium.org> wrote:

> On 2017/05/08 16:25:52, Nico wrote:
> > The bot went green one build after the revert went in, and the changes in
> > the next few builds were no-ops -- so it looks like that test failure was
> > probably due to vc2017.
> >
> > On May 7, 2017 7:56 PM, <mailto:thakis@chromium.org> wrote:
> >
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/2870523002/ by mailto:
> thakis@chromium.org.
> > >
> > > The reason for reverting is: We hopefully had a canary with this by
> now..
> > >
> > > https://codereview.chromium.org/2863313002/
>
> I'll investigate the failure, and check crash results for the VS 2017
> canary (or
> canaries). Do you know what canary builds ended up using VC 2017? I could
> download the packages but if you know off-hand that would be helpful.
>
>
> https://codereview.chromium.org/2863313002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brucedawson, 2017-05-15 18:50:20]

> > I'll investigate the failure, and check crash results for the VS 2017
> > canary (or
> > canaries). Do you know what canary builds ended up using VC 2017? I could
> > download the packages but if you know off-hand that would be helpful.

Back in the office now. I filed crbug.com/722480 for the test failures. We
didn't get any canaries due to PGO misconfigs that are being fixed.