third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc - Issue 2870413005: [LayoutNG] Add "Control" NGInlineItemType for newlines and tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc

Issue 2870413005: [LayoutNG] Add "Control" NGInlineItemType for newlines and tabs (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc

index 5fee20f12c3dce5bc5168870667adb262bfed359..dac3a1292c250aea7eaedbb1cb1efebf5e7e4b75 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc

@@ -245,6 +245,18 @@ TEST_F(NGInlineItemsBuilderTest, AppendEmptyString) {

EXPECT_EQ(0u, items_.size());

}

+TEST_F(NGInlineItemsBuilderTest, NewLines) {

+ SetWhiteSpace(EWhiteSpace::kPre);

+ EXPECT_EQ("apple\norange\ngrape\n", TestAppend("apple\norange\ngrape\n"));

+ EXPECT_EQ(6u, items_.size());

+ EXPECT_EQ(NGInlineItem::kText, items_[0].Type());

+ EXPECT_EQ(NGInlineItem::kControl, items_[1].Type());

+ EXPECT_EQ(NGInlineItem::kText, items_[2].Type());

+ EXPECT_EQ(NGInlineItem::kControl, items_[3].Type());

+ EXPECT_EQ(NGInlineItem::kText, items_[4].Type());

+ EXPECT_EQ(NGInlineItem::kControl, items_[5].Type());

TEST_F(NGInlineItemsBuilderTest, Empty) {

Vector<NGInlineItem> items;

NGInlineItemsBuilder builder(&items);