Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2870413002: Revert of [heap] Verify remembered set for objects in the old generation. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Verify remembered set for objects in the old generation. (patchset #3 id:40001 of https://codereview.chromium.org/2868053002/ ) Reason for revert: buildbot failures Original issue's description: > [heap] Verify remembered set for objects in the old generation. > > Review-Url: https://codereview.chromium.org/2868053002 > Cr-Commit-Position: refs/heads/master@{#45225} > Committed: https://chromium.googlesource.com/v8/v8/+/755a809ee5f91f5f63d5f056af37090960be002c TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2870413002 Cr-Commit-Position: refs/heads/master@{#45227} Committed: https://chromium.googlesource.com/v8/v8/+/8f89e28661af23b0aa163a265d906bf6a194fe3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -133 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ulan
Created Revert of [heap] Verify remembered set for objects in the old generation.
3 years, 7 months ago (2017-05-10 10:37:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870413002/1
3 years, 7 months ago (2017-05-10 10:37:33 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 10:37:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8f89e28661af23b0aa163a265d906bf6a19...

Powered by Google App Engine
This is Rietveld 408576698