[heap] Verify remembered set for objects in the old generation.

[heap] Verify remembered set for objects in the old generation.

Review-Url: https://codereview.chromium.org/2868053002
Cr-Commit-Position: refs/heads/master@{#45225}
Committed: https://chromium.googlesource.com/v8/v8/+/755a809ee5f91f5f63d5f056af37090960be002c

[ulan, 2017-05-09 15:00:46]

Description was changed from

==========
[heap] Verify remembered set for objects in olg generation.

BUG=
==========

to

==========
[heap] Verify remembered set for objects in the old generation.

BUG=
==========

[ulan, 2017-05-09 17:00:13]

Description was changed from

==========
[heap] Verify remembered set for objects in the old generation.

BUG=
==========

to

==========
[heap] Verify remembered set for objects in the old generation.
==========

[ulan, 2017-05-09 17:00:55]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2017-05-09 17:00:56]

ptal

[Michael Lippautz, 2017-05-09 17:44:05]

LGTM

https://codereview.chromium.org/2868053002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2868053002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4924: // of mark-compactor. Since there is precise check for
DescriptorArray and
/is/is no/

That is unfortunate :/

[ulan, 2017-05-10 09:19:35]

I removed old to old slot verification for now until we have instance types for
descriptors arrays and js weak collection backing stores.

[ulan, 2017-05-10 09:19:39]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-05-10 09:19:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2868053002/#ps40001
(title: "remove old to old handling")

[commit-bot: I haz the power, 2017-05-10 09:19:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 09:53:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494407979614710,
"parent_rev": "585428b8a1a8edcafb68c3a85eef5ae88e244054", "commit_rev":
"755a809ee5f91f5f63d5f056af37090960be002c"}

[commit-bot: I haz the power, 2017-05-10 09:53:16]

Description was changed from

==========
[heap] Verify remembered set for objects in the old generation.
==========

to

==========
[heap] Verify remembered set for objects in the old generation.

Review-Url: https://codereview.chromium.org/2868053002
Cr-Commit-Position: refs/heads/master@{#45225}
Committed:
https://chromium.googlesource.com/v8/v8/+/755a809ee5f91f5f63d5f056af37090960b...
==========

[commit-bot: I haz the power, 2017-05-10 09:53:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/755a809ee5f91f5f63d5f056af37090960b...

[ulan, 2017-05-10 10:37:28]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2870413002/ by ulan@chromium.org.

The reason for reverting is: buildbot failures.