Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2870393004: Revert of [v8] Mark layout tests for automatic rebaseline. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [v8] Mark layout tests for automatic rebaseline. (patchset #1 id:1 of https://codereview.chromium.org/2865113006/ ) Reason for revert: v8 got reverted and this is now one of the failing tests on https://crbug.com/720511 Original issue's description: > [v8] Mark layout tests for automatic rebaseline. > > Now that a V8 version with the new asm.js validator has been rolled into > Chromium, the affected layout tests can be automatically rebased. This > feature is not yet enabled. > > R=machenbach@chromium.org > BUG=chromium:718394 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2865113006 > Cr-Commit-Position: refs/heads/master@{#470286} > Committed: https://chromium.googlesource.com/chromium/src/+/1a0e41a86180a90bb523c9ae3b577b223f31aa87 TBR=machenbach@chromium.org,mstarzinger@chromium.org NOTRY=true BUG=chromium:718394 Review-Url: https://codereview.chromium.org/2870393004 Cr-Commit-Position: refs/heads/master@{#470979} Committed: https://chromium.googlesource.com/chromium/src/+/1852efa6e4d9c3353cd43d1815929d46e0f19a70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
Created Revert of [v8] Mark layout tests for automatic rebaseline.
3 years, 7 months ago (2017-05-11 16:18:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870393004/1
3 years, 7 months ago (2017-05-11 16:18:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/137147) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-11 16:23:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870393004/1
3 years, 7 months ago (2017-05-11 16:30:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870393004/1
3 years, 7 months ago (2017-05-11 16:37:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1852efa6e4d9c3353cd43d1815929d46e0f19a70
3 years, 7 months ago (2017-05-11 16:44:24 UTC) #14
Michael Starzinger
3 years, 7 months ago (2017-05-12 10:42:05 UTC) #15
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698