Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2865113006: [v8] Mark layout tests for automatic rebaseline. (Closed)

Created:
3 years, 7 months ago by Michael Starzinger
Modified:
3 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Mark layout tests for automatic rebaseline. Now that a V8 version with the new asm.js validator has been rolled into Chromium, the affected layout tests can be automatically rebased. This feature is not yet enabled. R=machenbach@chromium.org BUG=chromium:718394 NOTRY=true Review-Url: https://codereview.chromium.org/2865113006 Cr-Commit-Position: refs/heads/master@{#470286} Committed: https://chromium.googlesource.com/chromium/src/+/1a0e41a86180a90bb523c9ae3b577b223f31aa87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
PTAL.
3 years, 7 months ago (2017-05-09 11:48:23 UTC) #1
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-09 11:51:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865113006/1
3 years, 7 months ago (2017-05-09 11:52:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1a0e41a86180a90bb523c9ae3b577b223f31aa87
3 years, 7 months ago (2017-05-09 11:56:34 UTC) #7
Nico
3 years, 7 months ago (2017-05-11 16:18:21 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2870393004/ by thakis@chromium.org.

The reason for reverting is: v8 got reverted and this is now one of the failing
tests on https://crbug.com/720511.

Powered by Google App Engine
This is Rietveld 408576698