Tether: only scan when asked to by NetworkStateHandler.

Tether: only scan when asked to by NetworkStateHandler.

Tether will not necessarily always scan when asked to by NetworkStateHandler; if a scan is active or has recently finished, the request is a no-op.

BUG=672263
Review-Url: https://codereview.chromium.org/2870393003
Cr-Commit-Position: refs/heads/master@{#472481}
Committed: https://chromium.googlesource.com/chromium/src/+/65346fa38c3a010598bc61d5069691d2d2177f07

[Ryan Hansberry, 2017-05-15 23:29:17]

Description was changed from

==========
Tether: only scan when asked to by NetworkStateHandler.

BUG=672263
==========

to

==========
Tether: only scan when asked to by NetworkStateHandler.

Tether will not necessarily always scan when asked to by NetworkStateHandler; if
a scan is active or has recently finished, the request is a no-op.

BUG=672263
==========

[Ryan Hansberry, 2017-05-15 23:29:17]

hansberry@chromium.org changed reviewers:
+ jlklein@chromium.org, lesliewatkins@chromium.org

[Ryan Hansberry, 2017-05-15 23:30:08]

The CQ bit was checked by hansberry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:31:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 00:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:27:06]

Dry run: This issue passed the CQ dry run.

[Ryan Hansberry, 2017-05-16 22:13:38]

hansberry@chromium.org changed reviewers:
+ stevenjb@chromium.org
- jlklein@chromium.org

[Ryan Hansberry, 2017-05-16 22:17:43]

Hi stevenjb@: I'm adding you as a reviewer because unfortunately you know the
most about this codebase, besides myself, since khorimoto@ is OOO. This change
is fairly simple: 

* Refactors HostScanScheduler to use the
NetworkStateHandlerObserver::ScanRequested method (and remove a lot of
unnecessary stuff), which calls on HostScanner.
* Tweaks HostScanner to measure how long it's been since the last scan, in order
to make sure we only scan every 5 minutes.
* Adjusts initializer to accommodate for the 2 changes above.

Thanks!

[Ryan Hansberry, 2017-05-16 22:19:51]

The CQ bit was checked by hansberry@chromium.org to run a CQ dry run

[Ryan Hansberry, 2017-05-16 22:20:07]

hansberry@chromium.org changed reviewers:
- lesliewatkins@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:22:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-05-16 22:43:46]

lgtm

https://codereview.chromium.org/2870393003/diff/60001/chromeos/components/tet...
File chromeos/components/tether/host_scan_scheduler.cc (left):

https://codereview.chromium.org/2870393003/diff/60001/chromeos/components/tet...
chromeos/components/tether/host_scan_scheduler.cc:30: host_scan_scheduler);
If you are going to remove this you should remove the associated observer
methods also, otherwise you should go ahead and pass a PowerManagerClient
instance in this CL.

[commit-bot: I haz the power, 2017-05-17 00:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:05:59]

Dry run: This issue passed the CQ dry run.

[Ryan Hansberry, 2017-05-17 00:28:32]

https://codereview.chromium.org/2870393003/diff/60001/chromeos/components/tet...
File chromeos/components/tether/host_scan_scheduler.cc (left):

https://codereview.chromium.org/2870393003/diff/60001/chromeos/components/tet...
chromeos/components/tether/host_scan_scheduler.cc:30: host_scan_scheduler);
On 2017/05/16 22:43:45, stevenjb wrote:
> If you are going to remove this you should remove the associated observer
> methods also, otherwise you should go ahead and pass a PowerManagerClient
> instance in this CL.

Good point, done. I've removed the PowerManagerClient::Observer callback, but
fully implemented the NetworkStateHandlerObserver::DefaultNetworkChanged()
callback -- it starts a scan if the device is not connected to the Internet.
Please take a look.

[Ryan Hansberry, 2017-05-17 00:33:41]

The CQ bit was checked by hansberry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 00:36:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:01:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:01:40]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-05-17 16:43:24]

lgtm

[Ryan Hansberry, 2017-05-17 17:02:23]

The CQ bit was checked by hansberry@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:04:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:16:46]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495040543521500,
"parent_rev": "733abfce87eb65cf777c6c122654c2ef3310313c", "commit_rev":
"65346fa38c3a010598bc61d5069691d2d2177f07"}

[commit-bot: I haz the power, 2017-05-17 17:16:56]

Description was changed from

==========
Tether: only scan when asked to by NetworkStateHandler.

Tether will not necessarily always scan when asked to by NetworkStateHandler; if
a scan is active or has recently finished, the request is a no-op.

BUG=672263
==========

to

==========
Tether: only scan when asked to by NetworkStateHandler.

Tether will not necessarily always scan when asked to by NetworkStateHandler; if
a scan is active or has recently finished, the request is a no-op.

BUG=672263

Review-Url: https://codereview.chromium.org/2870393003
Cr-Commit-Position: refs/heads/master@{#472481}
Committed:
https://chromium.googlesource.com/chromium/src/+/65346fa38c3a010598bc61d50696...
==========

[commit-bot: I haz the power, 2017-05-17 17:16:57]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/65346fa38c3a010598bc61d50696...

[khorimoto, 2017-05-30 17:39:09]

khorimoto@google.com changed reviewers:
+ khorimoto@google.com

[khorimoto, 2017-05-30 17:39:10]

https://codereview.chromium.org/2870393003/diff/80001/chromeos/components/tet...
File chromeos/components/tether/initializer.cc (right):

https://codereview.chromium.org/2870393003/diff/80001/chromeos/components/tet...
chromeos/components/tether/initializer.cc:221: clock_ =
base::MakeUnique<base::DefaultClock>();
Can you just pass this to the HostScanner constructor? Doesn't seem like this
should be an instance field.