Tether: only scan when asked to by NetworkStateHandler.

chromeos/components/tether/initializer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/initializer.h"
 
 #include "base/bind.h"
 #include "chromeos/components/tether/active_host.h"
 #include "chromeos/components/tether/active_host_network_state_updater.h"
 #include "chromeos/components/tether/ble_connection_manager.h"
@@ skipping 200 matching lines @@
           active_host_.get(), network_state_handler_,
           network_configuration_remover_.get());
   network_connection_handler_tether_delegate_ =
       base::MakeUnique<NetworkConnectionHandlerTetherDelegate>(
           network_connection_handler_, tether_connector_.get(),
           tether_disconnector_.get());
   host_scan_cache_ = base::MakeUnique<HostScanCache>(
       network_state_handler_, active_host_.get(),
       tether_host_response_recorder_.get(),
       device_id_tether_network_guid_map_.get());
+  clock_ = base::MakeUnique<base::DefaultClock>();

[khorimoto, 2017/05/30 17:39:10]

Can you just pass this to the HostScanner constructor? Doesn't seem like this
should be an instance field.

   host_scanner_ = base::MakeUnique<HostScanner>(
       tether_host_fetcher_.get(), ble_connection_manager_.get(),
       host_scan_device_prioritizer_.get(), tether_host_response_recorder_.get(),
       notification_presenter_.get(), device_id_tether_network_guid_map_.get(),
-      host_scan_cache_.get());
+      host_scan_cache_.get(), clock_.get());
+  host_scan_scheduler_ = base::MakeUnique<HostScanScheduler>(
+      network_state_handler_, host_scanner_.get());
 
-  // TODO(khorimoto): Hook up HostScanScheduler. Currently, we simply start a
-  // new scan once the user logs in.
-  host_scanner_->StartScan();
+  // Because Initializer is created on each user log in, it's appropriate to
+  // call this method now.
+  host_scan_scheduler_->UserLoggedIn();
 }
 
 void Initializer::OnBluetoothAdapterAdvertisingIntervalError(
     device::BluetoothAdvertisement::ErrorCode status) {
   PA_LOG(ERROR) << "Failed to set Bluetooth advertisement interval; "
                 << "cannot use tether feature. Error code: " << status;
 }
 
 }  // namespace tether
 
 }  // namespace chromeos