Move message_center::CustomNotificationView to arc::ArcNotificationView

Move message_center::CustomNotificationView to arc::ArcNotificationView

We're having message_center::CustomNotificationView in ui/message_center separated from ui/arc, but it causes a lot of complexity of delegate. In other words, we have two abstraction layer: MessageView and CustomNotificationContentViewDelegate. But CustomNotificationView and CustomNotificationContentViewDelegate are only used by ARC so the later abstraction layer can be removed..

Currently CustomNotificationView is only used by ARC. So this CL moves it to ui/arc and renames it to ArcNotificationView to make the code simper in succeeding CLs.

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none

Review-Url: https://codereview.chromium.org/2870283002
Cr-Commit-Position: refs/heads/master@{#474693}
Committed: https://chromium.googlesource.com/chromium/src/+/4e9fc10cf30e41afad38069847381cd725c2acbe

[yoshiki, 2017-05-10 00:30:21]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:31:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-05-10 00:32:18]

Description was changed from

==========
.

BUG=
==========

to

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

This CL 


BUG=697359
TEST=none
==========

[commit-bot: I haz the power, 2017-05-10 02:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:37:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[yoshiki, 2017-05-10 03:38:55]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 03:39:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 06:10:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 06:10:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-10 09:09:53]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 09:10:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 10:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:08:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-10 10:44:58]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 10:45:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-05-10 10:48:41]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 10:48:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 13:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 13:04:49]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-05-10 13:13:14]

Patchset #2 (id:20001) has been deleted

[yoshiki, 2017-05-10 13:13:22]

Patchset #2 (id:40001) has been deleted

[yoshiki, 2017-05-10 13:20:10]

Description was changed from

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

This CL 


BUG=697359
TEST=none
==========

to

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

We're having message_center::CustomNotificationView in ui/message_center
separated from ui/arc, but it causes a lot of complexity of delegate. In other
words, we have two abstraction layer: MessageView and
CustomNotificationContentViewDelegate. But CustomNotificationView and
CustomNotificationContentViewDelegate are only used by ARC so the later
abstraction layer can be removed..

Currently CustomNotificationView is only used by ARC. So this CL moves it to
ui/arc and renames it to ArcNotificationView to make the code simper in
succeeding CLs.

BUG=697359
TEST=none
==========

[yoshiki, 2017-05-10 13:20:10]

yoshiki@chromium.org changed reviewers:
+ hidehiko@chromium.org

[yoshiki, 2017-05-10 13:21:52]

Description was changed from

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

We're having message_center::CustomNotificationView in ui/message_center
separated from ui/arc, but it causes a lot of complexity of delegate. In other
words, we have two abstraction layer: MessageView and
CustomNotificationContentViewDelegate. But CustomNotificationView and
CustomNotificationContentViewDelegate are only used by ARC so the later
abstraction layer can be removed..

Currently CustomNotificationView is only used by ARC. So this CL moves it to
ui/arc and renames it to ArcNotificationView to make the code simper in
succeeding CLs.

BUG=697359
TEST=none
==========

to

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

We're having message_center::CustomNotificationView in ui/message_center
separated from ui/arc, but it causes a lot of complexity of delegate. In other
words, we have two abstraction layer: MessageView and
CustomNotificationContentViewDelegate. But CustomNotificationView and
CustomNotificationContentViewDelegate are only used by ARC so the later
abstraction layer can be removed..

Currently CustomNotificationView is only used by ARC. So this CL moves it to
ui/arc and renames it to ArcNotificationView to make the code simper in
succeeding CLs.

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none
==========

[yoshiki, 2017-05-10 13:22:00]

yoshiki@chromium.org changed reviewers:
+ edcourtney@chromium.org, yhanada@chromium.org

[yoshiki, 2017-05-10 13:22:00]

yoshiki@chromium.org changed required reviewers:
+ hidehiko@chromium.org

[yoshiki, 2017-05-10 13:22:01]

Hidehiko-san, PTAL.

Eliot, Hanada-san, FYI.

[hidehiko, 2017-05-11 14:22:47]

Sorry for delay. Direction looks good. Mostly minor comments or document
requests.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_custom_notification_view.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_custom_notification_view.h:40: // TODO(yoshiki): Rename
this class to ArcNotificationContentsView.
As you TODO'ed now we have ArcNotificationView and ArcCustomNotificationView
(will be renamed to ArcNotificationContentsView). So, I think it is the time to
document these responsibilities.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_delegate.cc (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_delegate.cc:22:
ArcNotificationDelegate::~ArcNotificationDelegate() {}
nit: s/{}/= default;/

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_delegate.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_delegate.h:25: * Implementation of
NotificationDelegate for ARC notifications.
(Off-topic)/Style: Probably, '//' should be used here.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.cc:35: contents_view_ =
contents_view.release();
Could you initialize this in the initializer list with std::move()?

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.cc:39: contents_view_delegate_ =
std::move(contents_view_delegate);
Ditto.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.cc:51:
ArcNotificationView::~ArcNotificationView() {}
As you're here, could you s/{}/= default/?

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_view.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.h:25: ArcNotificationView(
Could you document the args? Specifically, |view| looks ambiguous (what's the
view here? IIUC content view?) at quick glance to me.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_view_unittest.cc (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view_unittest.cc:39:
~TestNotificationContentsView() override {}
Similarly, s/{}/= default;/

Ditto for below.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view_unittest.cc:183:
notification_.reset(new message_center::Notification(
nit/style: Could you use base::MakeUnique<> instead?

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view_unittest.cc:192:
notification_view_.reset(static_cast<ArcNotificationView*>(
Ditto.

https://codereview.chromium.org/2870283002/diff/50001/ui/message_center/notif...
File ui/message_center/notification_delegate.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/message_center/notif...
ui/message_center/notification_delegate.h:58: #if defined(TOOLKIT_VIEWS) &&
!defined(OS_MACOSX)
(Optional) Is this guard still necessary? Ditto for caller. If so, probably it
is good to be documented here.

[yoshiki, 2017-05-12 08:35:06]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 08:35:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-05-12 08:42:38]

Thanks! PTAL.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_custom_notification_view.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_custom_notification_view.h:40: // TODO(yoshiki): Rename
this class to ArcNotificationContentsView.
On 2017/05/11 14:22:47, hidehiko wrote:
> As you TODO'ed now we have ArcNotificationView and ArcCustomNotificationView
> (will be renamed to ArcNotificationContentsView). So, I think it is the time
to
> document these responsibilities.

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_delegate.cc (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_delegate.cc:22:
ArcNotificationDelegate::~ArcNotificationDelegate() {}
On 2017/05/11 14:22:47, hidehiko wrote:
> nit: s/{}/= default;/

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_delegate.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_delegate.h:25: * Implementation of
NotificationDelegate for ARC notifications.
On 2017/05/11 14:22:47, hidehiko wrote:
> (Off-topic)/Style: Probably, '//' should be used here.

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.cc:35: contents_view_ =
contents_view.release();
On 2017/05/11 14:22:47, hidehiko wrote:
> Could you initialize this in the initializer list with std::move()?

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.cc:39: contents_view_delegate_ =
std::move(contents_view_delegate);
On 2017/05/11 14:22:47, hidehiko wrote:
> Ditto.

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.cc:51:
ArcNotificationView::~ArcNotificationView() {}
On 2017/05/11 14:22:47, hidehiko wrote:
> As you're here, could you s/{}/= default/?

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_view.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view.h:25: ArcNotificationView(
On 2017/05/11 14:22:47, hidehiko wrote:
> Could you document the args? Specifically, |view| looks ambiguous (what's the
> view here? IIUC content view?) at quick glance to me.

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_view_unittest.cc (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view_unittest.cc:39:
~TestNotificationContentsView() override {}
On 2017/05/11 14:22:47, hidehiko wrote:
> Similarly, s/{}/= default;/
> 
> Ditto for below.

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view_unittest.cc:183:
notification_.reset(new message_center::Notification(
On 2017/05/11 14:22:47, hidehiko wrote:
> nit/style: Could you use base::MakeUnique<> instead?

Done.

https://codereview.chromium.org/2870283002/diff/50001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_view_unittest.cc:192:
notification_view_.reset(static_cast<ArcNotificationView*>(
On 2017/05/11 14:22:47, hidehiko wrote:
> Ditto.

This line doesn't construct an object so we can't use MakeUnique here.

https://codereview.chromium.org/2870283002/diff/50001/ui/message_center/notif...
File ui/message_center/notification_delegate.h (right):

https://codereview.chromium.org/2870283002/diff/50001/ui/message_center/notif...
ui/message_center/notification_delegate.h:58: #if defined(TOOLKIT_VIEWS) &&
!defined(OS_MACOSX)
On 2017/05/11 14:22:47, hidehiko wrote:
> (Optional) Is this guard still necessary? Ditto for caller. If so, probably it
> is good to be documented here.

I think this condition is obvious since this returns a view and mac chrome
doesn't support views notification.

[commit-bot: I haz the power, 2017-05-12 09:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 09:10:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-15 03:27:03]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 03:27:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 03:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 03:55:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-15 06:59:59]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 07:00:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 08:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 08:56:21]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-05-15 13:52:17]

LGTM with minor comment.

For ASAN failure, it looks crbug.com/722123, but please re-run and verify it is
hitting flakiness, before submitting.

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
ui/arc/notification/arc_notification_view.cc:33:
contents_view_(contents_view.release()),
Please use std::move, instead, for consistency.

[yoshiki, 2017-05-15 15:48:53]

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
ui/arc/notification/arc_notification_view.cc:33:
contents_view_(contents_view.release()),
On 2017/05/15 13:52:16, hidehiko wrote:
> Please use std::move, instead, for consistency.

Let me double-check. |contents_view_| is a raw pointer. Is it really better to
use std::move?

[hidehiko, 2017-05-16 11:16:28]

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
ui/arc/notification/arc_notification_view.cc:33:
contents_view_(contents_view.release()),
On 2017/05/15 15:48:53, yoshiki wrote:
> On 2017/05/15 13:52:16, hidehiko wrote:
> > Please use std::move, instead, for consistency.
> 
> Let me double-check. |contents_view_| is a raw pointer. Is it really better to
> use std::move?

Ah, sorry, I misunderstood.
So, the ownership is transferred to AddChildView, then, I'd recommend to use
.get() here, and use .release() in AddChildView(). So;

contents_view_(contents_view.get());
  :
{
  :
  DCHECK(contents_view_);
  AddChildView(contents_view_.release());
  :
}

[yoshiki, 2017-05-23 15:14:21]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 15:15:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 15:39:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-23 18:06:02]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 18:06:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:07:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yoshiki, 2017-05-24 00:36:40]

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
File ui/arc/notification/arc_notification_view.cc (right):

https://codereview.chromium.org/2870283002/diff/110001/ui/arc/notification/ar...
ui/arc/notification/arc_notification_view.cc:33:
contents_view_(contents_view.release()),
On 2017/05/16 11:16:28, hidehiko wrote:
> On 2017/05/15 15:48:53, yoshiki wrote:
> > On 2017/05/15 13:52:16, hidehiko wrote:
> > > Please use std::move, instead, for consistency.
> > 
> > Let me double-check. |contents_view_| is a raw pointer. Is it really better
to
> > use std::move?
> 
> Ah, sorry, I misunderstood.
> So, the ownership is transferred to AddChildView, then, I'd recommend to use
> .get() here, and use .release() in AddChildView(). So;
> 
> contents_view_(contents_view.get());
>   :
> {
>   :
>   DCHECK(contents_view_);
>   AddChildView(contents_view_.release());
>   :
> }

Done. Thanks.

[yoshiki, 2017-05-24 00:36:45]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2017-05-24 00:36:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org
Link to the patchset: https://codereview.chromium.org/2870283002/#ps150001
(title: "Addressed comment and fixed BUILD.gn")

[commit-bot: I haz the power, 2017-05-24 00:38:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:51:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoshiki, 2017-05-24 02:40:15]

yoshiki@chromium.org changed reviewers:
+ kbr@chromium.org

[yoshiki, 2017-05-24 02:40:15]

yoshiki@chromium.org changed required reviewers:
+ kbr@chromium.org

[yoshiki, 2017-05-24 02:40:15]

kbr@, could you approve depending on ui/gl? We're calling some GL method from
ui/arc/test/run_all_unittests.cc.

[Ken Russell (switch to Gerrit), 2017-05-24 20:48:11]

https://codereview.chromium.org/2870283002/diff/150001/ui/arc/DEPS
File ui/arc/DEPS (right):

https://codereview.chromium.org/2870283002/diff/150001/ui/arc/DEPS#newcode4
ui/arc/DEPS:4: "+ui/gl",
Rather than adding this dependency, which could lead to undesirable
interdependencies in the future, could you instead add an include_rule allowing
ui/gl/test in a new ui/arc/test/DEPS file? It looks like the only real
dependency is calling gl::GLSurfaceTestSupport::InitializeOneOff() from
ui/arc/test/run_all_unittests.cc.

[yoshiki, 2017-05-25 05:45:37]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 05:45:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 07:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 07:12:31]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-05-25 07:27:29]

kbr@, PTAL again? Thanks.

https://codereview.chromium.org/2870283002/diff/150001/ui/arc/DEPS
File ui/arc/DEPS (right):

https://codereview.chromium.org/2870283002/diff/150001/ui/arc/DEPS#newcode4
ui/arc/DEPS:4: "+ui/gl",
On 2017/05/24 20:48:10, Ken Russell wrote:
> Rather than adding this dependency, which could lead to undesirable
> interdependencies in the future, could you instead add an include_rule
allowing
> ui/gl/test in a new ui/arc/test/DEPS file? It looks like the only real
> dependency is calling gl::GLSurfaceTestSupport::InitializeOneOff() from
> ui/arc/test/run_all_unittests.cc.

Thank you for guidance. I updated the DEPS.

[Ken Russell (switch to Gerrit), 2017-05-25 17:35:18]

lgtm

[yoshiki, 2017-05-25 17:40:09]

Thanks!

[yoshiki, 2017-05-25 17:40:30]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2017-05-25 17:40:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org
Link to the patchset: https://codereview.chromium.org/2870283002/#ps170001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-05-25 17:41:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:46:12]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1495734030942410,
"parent_rev": "7f03309fde80e0cf33cb99519d2716cb5160aac6", "commit_rev":
"4e9fc10cf30e41afad38069847381cd725c2acbe"}

[commit-bot: I haz the power, 2017-05-25 17:46:24]

Description was changed from

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

We're having message_center::CustomNotificationView in ui/message_center
separated from ui/arc, but it causes a lot of complexity of delegate. In other
words, we have two abstraction layer: MessageView and
CustomNotificationContentViewDelegate. But CustomNotificationView and
CustomNotificationContentViewDelegate are only used by ARC so the later
abstraction layer can be removed..

Currently CustomNotificationView is only used by ARC. So this CL moves it to
ui/arc and renames it to ArcNotificationView to make the code simper in
succeeding CLs.

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none
==========

to

==========
Move message_center::CustomNotificationView to arc::ArcNotificationView

We're having message_center::CustomNotificationView in ui/message_center
separated from ui/arc, but it causes a lot of complexity of delegate. In other
words, we have two abstraction layer: MessageView and
CustomNotificationContentViewDelegate. But CustomNotificationView and
CustomNotificationContentViewDelegate are only used by ARC so the later
abstraction layer can be removed..

Currently CustomNotificationView is only used by ARC. So this CL moves it to
ui/arc and renames it to ArcNotificationView to make the code simper in
succeeding CLs.

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none

Review-Url: https://codereview.chromium.org/2870283002
Cr-Commit-Position: refs/heads/master@{#474693}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e9fc10cf30e41afad3806984738...
==========

[commit-bot: I haz the power, 2017-05-25 17:46:26]

Committed patchset #8 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/4e9fc10cf30e41afad3806984738...