ui/arc/DEPS - Issue 2870283002: Move message_center::CustomNotificationView to arc::ArcNotificationView

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/arc/DEPS

Issue 2870283002: Move message_center::CustomNotificationView to arc::ArcNotificationView (Closed)

Patch Set: Addressed comment and fixed BUILD.gn Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+ash",	2 "+ash",

3 "+components/arc",	3 "+components/arc",

	4 "+ui/gl",
	Ken Russell (switch to Gerrit) 2017/05/24 20:48:10 Rather than adding this dependency, which could le Rather than adding this dependency, which could lead to undesirable interdependencies in the future, could you instead add an include_rule allowing ui/gl/test in a new ui/arc/test/DEPS file? It looks like the only real dependency is calling gl::GLSurfaceTestSupport::InitializeOneOff() from ui/arc/test/run_all_unittests.cc. yoshiki 2017/05/25 07:27:28 Thank you for guidance. I updated the DEPS. Show quoted text On 2017/05/24 20:48:10, Ken Russell wrote: > Rather than adding this dependency, which could lead to undesirable > interdependencies in the future, could you instead add an include_rule allowing > ui/gl/test in a new ui/arc/test/DEPS file? It looks like the only real > dependency is calling gl::GLSurfaceTestSupport::InitializeOneOff() from > ui/arc/test/run_all_unittests.cc. Thank you for guidance. I updated the DEPS.
4 "+mojo",	5 "+mojo",

5 ]	6 ]

OLD	NEW

« no previous file with comments | « ui/arc/BUILD.gn ('k') | ui/arc/notification/arc_custom_notification_view.h » ('j') | no next file with comments »